Skip to content

Commit 14c68e3

Browse files
committed
fixing issue with span bottleneck zero value
1 parent c8d9db9 commit 14c68e3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/views/codeAnalytics/InsightListView/SpanInsight.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,15 @@ export class SpanUsagesListViewItemsCreator implements IInsightListViewItemsCrea
6666

6767
let lastServiceHtml = '';
6868
if(flow.lastService) {
69+
var lastServiceLocation = await this._spanLinkResolver.searchForSpanByHints({
70+
spanName :flow.lastService.span,
71+
codeObjectId: flow.lastService.codeObjectId,
72+
});
6973
lastServiceHtml = /*html*/`
7074
<span class="codicon codicon-arrow-small-right"></span>
7175
<span class="flow-entry ellipsis" title="${flow.lastService.service}: ${flow.lastService.span}">
7276
<span class="flow-service">${flow.lastService.service}:</span>
73-
<span class="flow-span">${flow.lastService.span}</span>
77+
<span class="flow-span span-name ${lastServiceLocation ? "link" : ""}" data-code-uri="${lastServiceLocation?.documentUri}" data-code-line="${lastServiceLocation?.range.end.line!+1}">${flow.lastService.span}</span>
7478
</span>`;
7579
}
7680

@@ -417,7 +421,7 @@ export class SpanEndpointBottlenecksListViewItemsCreator implements IInsightList
417421
}
418422

419423
private getDescription(span: SlowEndpointInfo){
420-
if (span.p95){
424+
if (span.p95 && span.p95.fraction>0){
421425
return `Up to ~${(span.p95.fraction*100.0).toFixed(3)}% of the entire request time (${span.p95.maxDuration.value}${span.p95.maxDuration.unit}).`;
422426

423427
}

0 commit comments

Comments
 (0)