Lint

Author: Noam Kfir

src/extension.ts

@@ -36,9 +36,9 @@ export async function activate(context: vscode.ExtensionContext)
     const codeInspector = new CodeInspector();
     const symbolProvider = new SymbolProvider(supportedLanguages, codeInspector);
     const analyticsProvider = new AnalyticsProvider(workspaceState);
-    const documentInfoProvider = new DocumentInfoProvider(analyticsProvider, symbolProvider,workspaceState);
+    const documentInfoProvider = new DocumentInfoProvider(analyticsProvider, symbolProvider, workspaceState);
     const editorHelper = new EditorHelper(sourceControl, documentInfoProvider);
-    const codeLensProvider = new AnaliticsCodeLens(documentInfoProvider,workspaceState)
+    const codeLensProvider = new AnaliticsCodeLens(documentInfoProvider, workspaceState);
 
     if(!workspaceState.environment){
         const firstEnv = (await analyticsProvider.getEnvironments()).firstOrDefault();

src/services/EditorHelper.ts

@@ -30,80 +30,68 @@ export class EditorHelper {
         private _documentInfoProvider: DocumentInfoProvider,
     ) {}
 
-    public async goToFileAndLine(editorInfo?: EditorInfo)
-    {
+    public async goToFileAndLine(editorInfo?: EditorInfo) {
         if(!editorInfo?.workspaceUri) {
             return;
         }
 
         const workspaceUri = editorInfo.workspaceUri;
         const lineNumber = editorInfo.lineNumber ?? 0;
 
-        try
-        {
+        try {
             let doc: vscode.TextDocument | undefined = undefined;
 
-            if(!await utils.fileExists(workspaceUri))
-            {
+            if(!await utils.fileExists(workspaceUri)) {
                 doc = await this.askAndOpenFromSourceControl(editorInfo);
             }
-            else
-            {
+            else {
                 doc = await vscode.workspace.openTextDocument(workspaceUri);
 
                 const txtLine = doc.lineAt(lineNumber-1);
-                var fileChanged:boolean = false;
-                if (editorInfo.executedCode){
+                let fileChanged:boolean = false;
+                if (editorInfo.executedCode) {
                     fileChanged = (txtLine.text.trim() !== editorInfo.executedCode);
                 }
                 else {
                     try {
-                        var sourceDoc = await this.getFromSourceControl(workspaceUri, editorInfo.lastInstanceCommitId!);
-                        if (sourceDoc){
+                        const sourceDoc = await this.getFromSourceControl(workspaceUri, editorInfo.lastInstanceCommitId!);
+                        if (sourceDoc) {
                             fileChanged = (txtLine.text.trim() !== sourceDoc.lineAt(lineNumber-1).text.trim());
                         }
-                        else{
+                        else {
                             return;
                         }
                     }
-                    catch (exeption){
+                    catch(exeption) {
                         await vscode.window.showWarningMessage(
                             'Cannot locate file in source control. Please make sure its checked in');
                     }
-                
-
                 }
-                if(fileChanged)
-                {
+                if(fileChanged) {
                     doc = await this.askAndOpenFromSourceControl(editorInfo);;
                 }
-                else
-                {
+                else {
                     const docInfo = await this._documentInfoProvider.getDocumentInfo(doc);
                     const methodInfos = docInfo?.methods || [];
-                    if(methodInfos.all(m => m.symbol.name != editorInfo.functionName))
-                    {
+                    if(methodInfos.all(m => m.symbol.name != editorInfo.functionName)) {
                         doc = await this.askAndOpenFromSourceControl(editorInfo);
                     }
                 }
             }
 
-            if(doc)
-            {
+            if(doc) {
                 await this.openFileAndLine(doc, lineNumber); 
             }
         }
-        catch(error)
-        {
+        catch(error) {
             Logger.error(`Failed to open file: ${editorInfo.modulePhysicalPath}`, error);
             vscode.window.showErrorMessage(`Failed to open file: ${editorInfo.modulePhysicalPath}`)
         }
     }
 
-    public async openTextDocumentFromUri(uri: vscode.Uri) : Promise<vscode.TextDocument>{
+    public async openTextDocumentFromUri(uri: vscode.Uri) : Promise<vscode.TextDocument> {
         let doc = await vscode.workspace.openTextDocument(uri);
         return doc;
-
     }
 
     public async openFileAndLine(doc: vscode.TextDocument, lineNumber: number) {
@@ -118,18 +106,16 @@ export class EditorHelper {
         return await vscode.window.showTextDocument(doc);
     }
 
-    private async askAndOpenFromSourceControl(editorInfo: EditorInfo) : Promise<vscode.TextDocument | undefined>
-    {
-        if(!this._sourceControl.current)
-        {
+    private async askAndOpenFromSourceControl(editorInfo: EditorInfo) : Promise<vscode.TextDocument | undefined> {
+        if(!this._sourceControl.current) {
             const sel = await vscode.window.showWarningMessage(
                 'File version is different from the version recorded in this flow.\nPlease configure source control.',
                 'configure');
-            if(sel == 'configure')
+            if(sel == 'configure') {
                 await vscode.commands.executeCommand("workbench.action.openWorkspaceSettings", {query: Settings.sourceControl.key});
+            }
         }
-        else
-        {
+        else {
             let sel = await vscode.window.showWarningMessage(
                 `File version is different from the version recorded in this flow, would you like to open the remote version of the file' installed.`,
                 'yes'
@@ -180,8 +166,8 @@ export class EditorHelper {
     }
 
     public async getExecutedCodeFromScm(uri: vscode.Uri, commit: string, line: integer) : Promise<string |undefined>{
-        var doc = await this.getFromSourceControl(uri, commit);
-        if (doc){
+        const doc = await this.getFromSourceControl(uri, commit);
+        if (doc) {
             return doc.lineAt(line-1).text.trim();
         }
     }

src/services/languages/csharp/languageExtractor.ts

@@ -8,8 +8,7 @@ import { CSharpParametersExtractor } from './parametersExtractor';
 import { CSharpSpanExtractor } from './spanExtractor';
 // import { AspNetCoreMvcEndpointExtractor } from './AspNetCoreMvcEndpointExtractor';
 
-export class CSharpLanguageExtractor extends LanguageExtractor 
-{
+export class CSharpLanguageExtractor extends LanguageExtractor {
     public requiredExtensionLoaded: boolean = false;
 
     public get requiredExtensionId(): string {

src/services/languages/go/languageExtractor.ts

@@ -7,8 +7,7 @@ import { IModulePathToUriConverter, LogicalModulePathToUriConverter, PhysicalMod
 import { GoMethodExtractor } from './methodExtractor';
 import { GoSpanExtractor } from './spanExtractor';
 
-export class GoLanguageExtractor extends LanguageExtractor 
-{
+export class GoLanguageExtractor extends LanguageExtractor {
     public requiredExtensionLoaded: boolean = false;
 
     public get requiredExtensionId(): string {

src/services/languages/javascript/languageExtractor.ts

@@ -10,9 +10,7 @@ import { JSSpanExtractor } from './spanExtractor';
 import { JSPackageReader } from './packageReader';
 import { JSPackageToUriConverter } from './modulePathToUriConverters';
 
-export class JSLanguageExtractor extends LanguageExtractor 
-{
-
+export class JSLanguageExtractor extends LanguageExtractor {
     private packageReader: JSPackageReader = new JSPackageReader();
     public requiredExtensionLoaded: boolean = false;
 

src/services/languages/python/languageExtractor.ts

@@ -6,9 +6,7 @@ import { IModulePathToUriConverter, PhysicalModulePathToUriConverter } from '../
 import { PythonMethodExtractor } from './methodExtractor';
 import { PythonSpanExtractor } from './spanExtractor';
 
-
-export class PythonLanguageExtractor extends LanguageExtractor 
-{
+export class PythonLanguageExtractor extends LanguageExtractor {
     public requiredExtensionLoaded: boolean = false;
 
     public get requiredExtensionId(): string {

src/views/codeAnalytics/errorsViewTab.ts

@@ -26,8 +26,7 @@ import { WorkspaceState } from "../../state";
 import { ErrorsLineDecorator } from "./decorators/errorsLineDecorator";
 import { ErrorFlowParameterDecorator } from "./decorators/errorFlowParameterDecorator";
 
-export class ErrorsViewTab implements ICodeAnalyticsViewTab 
-{
+export class ErrorsViewTab implements ICodeAnalyticsViewTab {
     private _viewedCodeObjectId?: string = undefined;
     private _stackViewModel?: ErrorFlowStackViewModel = undefined;
     private _disposables: vscode.Disposable[] = [];
@@ -38,7 +37,6 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
         public static readonly ShowErrorView = `digma.ErrorView.show`;
     };
 
-
     constructor(
         private _channel: WebviewChannel,
         private _analyticsProvider: AnalyticsProvider,
@@ -61,7 +59,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
 
         this._disposables.push(vscode.commands.registerCommand(ErrorsViewTab.Commands.ShowErrorView, async (codeObjectId: string, codeObjectDisplayName: string, errorSourceUID: string) => {
             const view = this._webViewProvider.get();
-            if(view === undefined || view.visible === false){
+            if(view === undefined || view.visible === false) {
 
                 this._channel.consume(UiMessage.Notify.TabLoaded, async (e: UiMessage.Notify.TabLoaded)=>{
                         this.onShowErrorDetailsEvent(new UiMessage.Get.ErrorDetails(errorSourceUID));
@@ -130,7 +128,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
         }
         const document = editor.document;
         let docInfo = await this._documentInfoProvider.getDocumentInfo(document);
-        if (!docInfo){
+        if (!docInfo) {
             return;
         }
 
@@ -157,7 +155,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
             }
             catch(e)
             {
-                if(!(e instanceof HttpError) || e.status !== 404){
+                if(!(e instanceof HttpError) || e.status !== 404) {
                     Logger.error(`Failed to get codeObject ${codeObject.id} errors`, e);
                     const html = HtmlHelper.getErrorMessage("Failed to fetch errors from Digma server.\nSee Output window from more info.");
                     this._channel.publish(new UiMessage.Set.ErrorsList(html));
@@ -171,7 +169,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
 
             const codeObjectGroupEnv = new CodeObjectGroupEnvironments(this._webViewUris, this._workspaceState);
 
-            if (errors.length==0){
+            if (errors.length == 0) {
                 let html =codeObjectGroupEnv.getUsageHtml(undefined,undefined,usageResults);
                 html += `${HtmlHelper.getInfoMessage("Great news! No errors recorded here yet. Fingers crossed...")}`;
                 this._channel.publish(new UiMessage.Set.ErrorsList(html));
@@ -188,10 +186,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
         }
     }
 
-    
-
-    
-    private async onShowErrorDetailsEvent(e: UiMessage.Get.ErrorDetails){
+    private async onShowErrorDetailsEvent(e: UiMessage.Get.ErrorDetails) {
         if(!e.errorSourceUID) {
             return;
         }
@@ -210,15 +205,15 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
         const stackViewModel = viewModels.firstOrDefault();
         this._stackViewModel = stackViewModel;
         this._stackViewModels = viewModels;
-        let html = ErrorsHtmlBuilder.buildErrorDetails(errorDetails,  viewModels);
+        const html = ErrorsHtmlBuilder.buildErrorDetails(errorDetails, viewModels);
         this._overlay.show(html, this.errorOverlayId);
         this.navigateErrorFlow();
         this.updateEditorDecorations(stackViewModel);
     }
 
     private onOverlayVisibilityChanged(e: UiMessage.Notify.OverlayVisibilityChanged)
     {
-        if(e.visible !== undefined && e.id ===this.errorOverlayId){//error overlay visibility changed
+        if(e.visible !== undefined && e.id === this.errorOverlayId) {//error overlay visibility changed
             this._errorFlowParamDecorator.enabled = e.visible;
         }
     }
@@ -284,7 +279,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
                         moduleName,
                         functionName,
                         lineNumber,
-                        executedCode: executedCode,
+                        executedCode,
                         codeObjectId,
                         parameters,
                         repeat,
@@ -311,7 +306,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
                         moduleName,
                         functionName,
                         lineNumber,
-                        executedCode: executedCode,
+                        executedCode,
                         codeObjectId,
                         repeat,
                         workspaceUri,
@@ -334,7 +329,7 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
                 lastInstanceCommitId: sourceFlow.lastInstanceCommitId,
                 affectedSpanPaths: [],
                 exceptionType: '',
-                summary: undefined
+                summary: undefined,
             };
             viewModels.push(viewModel);
         }
@@ -365,24 +360,27 @@ export class ErrorsViewTab implements ICodeAnalyticsViewTab
         if(!docInfo){
             return;
         }
-        
+
         const methodInfo = docInfo?.methods.firstOrDefault((m) => m.range.contains(position));
-        if(!methodInfo){
+        if(!methodInfo) {
             return;
         }
 
-        const codeObject = <CodeObjectInfo>{ 
-            id: methodInfo.symbol.id, 
-            methodName: methodInfo.displayName 
+        const codeObject = <CodeObjectInfo>{
+            id: methodInfo.symbol.id,
+            methodName: methodInfo.displayName,
         };
         return codeObject;
     }
 
-    private async onWorkspaceOnlyChanged(value?: boolean){
-        if(value != undefined)
+    private async onWorkspaceOnlyChanged(value?: boolean) {
+        if(value != undefined) {
             await Settings.hideFramesOutsideWorkspace.set(value);
+        }
     }
+
     private errorOverlayId = "errorOverlay";
+
     private async goToFileAndLineById(frameId?: number) {
         const frame = this._stackViewModel?.stacks
             .flatMap(s => s.frames)