Skip to content

Commit 2ae851c

Browse files
authored
Added durations to span-scaling-insight (#225)
1 parent 8405585 commit 2ae851c

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

src/views/codeAnalytics/InsightListView/SpanInsight.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,8 @@ export interface SpanScalingInsight extends CodeObjectInsight {
181181
spanName: string;
182182
turningPointConcurrency: number;
183183
maxConcurrency: number;
184+
minDuration: Duration;
185+
maxDuration: Duration;
184186
}
185187

186188
export class SpanDurationsListViewItemsCreator implements IInsightListViewItemsCreator{
@@ -500,8 +502,13 @@ export class SpanScalingListViewItemsCreator implements IInsightListViewItemsCre
500502
},
501503
description: `Significant performance degradation at ${codeObjectsInsight.turningPointConcurrency} executions/second`,
502504
icon: this._viewUris.image("scale.svg"),
503-
body: `<div>
504-
Tested concurrency: ${codeObjectsInsight.maxConcurrency}
505+
body: `<div class="flex-row">
506+
<span>
507+
Tested concurrency: <b>${codeObjectsInsight.maxConcurrency}</b>
508+
</sapn>
509+
<span style="margin-left: 1em;">
510+
Duration: <b>${codeObjectsInsight.minDuration.value} ${codeObjectsInsight.minDuration.unit} - ${codeObjectsInsight.maxDuration.value} ${codeObjectsInsight.maxDuration.unit}<b/>
511+
</sapn>
505512
</div>`,
506513
insight: codeObjectsInsight,
507514
}, this._viewUris);

0 commit comments

Comments
 (0)