Only show module physical path without "in" when the function name is empty when rendering an error frame

Noam Kfir · Noam Kfir · commit 2f6ddb658347 · 2022-10-24T19:20:18.000+03:00
diff --git a/src/views/codeAnalytics/errorFlowStackRenderer.ts b/src/views/codeAnalytics/errorFlowStackRenderer.ts
@@ -265,7 +265,8 @@ export class ErrorFlowStackRenderer {
 
     private static getFrameItemHtml(frame: FrameViewModel)
     {
-        const path = `${frame.modulePhysicalPath} in ${frame.functionName}`;
+        const functionName = frame.functionName?.trim().length > 0 ? ` in ${frame.functionName}` : '';
+        const path = frame.modulePhysicalPath + functionName;
         const selectedClass = frame.selected ? "selected" : "";
         const disabledClass = frame.workspaceUri ? "" : "disabled";
         const hidden = Settings.hideFramesOutsideWorkspace.value && !frame.workspaceUri ? "hidden" : "";

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,8 @@ export class ErrorFlowStackRenderer {`
`265`	`265`
`266`	`266`	`private static getFrameItemHtml(frame: FrameViewModel)`
`267`	`267`	`{`
`268`		- const path = `${frame.modulePhysicalPath} in ${frame.functionName}`;
	`268`	+ const functionName = frame.functionName?.trim().length > 0 ? ` in ${frame.functionName}` : '';
	`269`	`+ const path = frame.modulePhysicalPath + functionName;`
`269`	`270`	`const selectedClass = frame.selected ? "selected" : "";`
`270`	`271`	`const disabledClass = frame.workspaceUri ? "" : "disabled";`
`271`	`272`	`const hidden = Settings.hideFramesOutsideWorkspace.value && !frame.workspaceUri ? "hidden" : "";`