Merge pull request #276 from digma-ai/fix/n-plus-one-pagination

Add pagination to Endpoint N-Plus-One insight

Author: kshmidt-digma

src/views-ui/codeAnalytics/main.scss

@@ -85,6 +85,7 @@ vscode-panel-view {
     padding: 1px 5px 2px 5px;
     border: none;
     color: inherit;
+    height: fit-content;
 
     &:disabled {
         opacity: 0.4;

src/views/codeAnalytics/InsightListView/EndpointInsight.ts

@@ -332,63 +332,79 @@ export class EPNPlusSpansListViewItemsCreator
     public async createListViewItem(
         codeObjectsInsight: EPNPlusSpansInsight
     ): Promise<IListViewItem> {
-        const spans = codeObjectsInsight.spans.filter((x) => x.internalSpan);
-
-        const hints: CodeObjectLocationHints[] =
-            this._spanLinkResolver.codeHintsFromSpans(
-                spans.map((x) => x.internalSpan)
-            );
-
-        const spansLocations =
-            await this._spanLinkResolver.searchForSpansByHints(hints);
+        const items = [];
+        for (const span of codeObjectsInsight.spans) {
+            let result;
+            if (span.internalSpan) {
+                const hints: CodeObjectLocationHints[] =
+                    this._spanLinkResolver.codeHintsFromSpans([
+                        span.internalSpan
+                    ]);
+
+                const spansLocations =
+                    await this._spanLinkResolver.searchForSpansByHints(hints);
+
+                result = spansLocations[0];
+            }
 
-        const items: string[] = [];
+            let fractionSt = "";
+            const fraction = span.fraction;
+            if (fraction < 0.01) {
+                fractionSt = "minimal";
+            } else {
+                fractionSt = `${fraction.toPrecision(1)} of request`;
+            }
 
-        for (let i = 0; i < spansLocations.length; i++) {
-            const result = spansLocations[i];
-            const slowSpan = spans[i];
+            const traceHtml = renderTraceLink(
+                span.traceId,
+                codeObjectsInsight.spanInfo?.name ||
+                    codeObjectsInsight.endpointSpan
+            );
 
             items.push(`
-                <div class="endpoint-bottleneck-insight" >
-                    <div class="span-name flex-row ${
-                        result ? "link" : ""
-                    }" data-code-uri="${result?.documentUri}" data-code-line="${
-                result?.range.end.line! + 1
-            }">
-                        <span class="left-ellipsis">${
-                            slowSpan.internalSpan.displayName
-                        }</span>
+                <div class="item vertical-spacer">
+                    <div class="endpoint-bottleneck-insight">
+                        <div class="span-name flex-row ${
+                            result ? "link" : ""
+                        }" data-code-uri="${
+                result?.documentUri
+            }" data-code-line="${result?.range.end.line! + 1}">
+                            <span class="left-ellipsis">${
+                                span.internalSpan
+                                    ? span.internalSpan.displayName
+                                    : span.clientSpan.displayName
+                            }</span>
+                        </div>
                     </div>
-                </div>`);
+                    <div style="margin-top:0.5em" class="flex-row">
+                        <span class="error-property flex-stretch">
+                            <span class="label">Impact</span>
+                            <span>${fractionSt}</span>
+                        </span>
+                        <span class="error-property flex-stretch">
+                            <span class="label">Repeats</span>
+                            <span>${span.occurrences}</span>
+                        </span>
+                        <span class="error-property flex-stretch">
+                            <span class="label">Duration</span>
+                            <span>${span.duration.value} ${
+                span.duration.unit
+            }</span>
+                        </span>
+                        ${traceHtml}
+                    </div>
+                </div>
+            `);
         }
 
-        const traceHtml = renderTraceLink(
-            codeObjectsInsight.spans.firstOrDefault()?.traceId,
-            codeObjectsInsight.spanInfo?.name || codeObjectsInsight.endpointSpan
-        );
-
-        let fractionSt = "";
-        const fraction = codeObjectsInsight.spans.firstOrDefault()?.fraction;
-        if (fraction < 0.01) {
-            fractionSt = "minimal";
-        } else {
-            fractionSt = `${fraction.toPrecision(1)} of request`;
-        }
-        const statsHtml = `
-        <div style="margin-top:0.5em" class="flex-row">
-                            
-            <span class="error-property flex-stretch">
-                <span class="label">Impact</span>
-                <span>${fractionSt}</span>
-            </span>
-            <span class="error-property flex-stretch">
-                <span class="label">Duration</span>
-                <span>${
-                    codeObjectsInsight.spans.firstOrDefault().duration.value
-                } ${
-            codeObjectsInsight.spans.firstOrDefault().duration.unit
-        }</span>
-            </span>
+        const bodyHtml = /*html*/ `
+            <div class="pagination-list" data-current-page="1" data-records-per-page="1">
+                ${items.join("")}
+                <div class="pagination-nav">
+                    <a class="prev">Prev</a>
+                    <a class="next">Next</a>
+                    <span class="page"></span>
+                </div>
             </div>
         `;
 
@@ -401,11 +417,10 @@ export class EPNPlusSpansListViewItemsCreator
                 },
                 description: "Check the following locations:",
                 icon: this._viewUris.image("sql.png"),
-                body: ` <div>
-                        ${items.join("")}
+                body: `<div>
+                        ${bodyHtml}
                     </div>
-                    ${statsHtml}`,
-                buttons: [traceHtml],
+                   `,
                 insight: codeObjectsInsight
             },
             this._viewUris