Skip to content

Commit 57811ca

Browse files
author
Noam Kfir
committed
Lint
1 parent e4c474d commit 57811ca

File tree

6 files changed

+42
-18
lines changed

6 files changed

+42
-18
lines changed

‎src/views-ui/codeAnalytics/contracts.ts‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { decimal } from "vscode-languageclient"
1+
import { decimal } from "vscode-languageclient";
22

33
export namespace UiMessage
44
{
@@ -7,6 +7,7 @@ export namespace UiMessage
77
export class TabLoaded {
88
constructor(public selectedViewId?: string) {}
99
}
10+
1011
export class TabChanged {
1112
constructor(public viewId?: string) {}
1213
}
@@ -19,9 +20,11 @@ export namespace UiMessage
1920
constructor(public environment?: string) {}
2021

2122
}
23+
2224
export class GoToLine{
2325
constructor(public line?: number){}
2426
}
27+
2528
export class GoToLineByFrameId {
2629
constructor(public frameId?: number){}
2730
}
@@ -37,18 +40,23 @@ export namespace UiMessage
3740
export class OpenTracePanel {
3841
constructor(public traceIds?: string[], public traceLabels?:string[], public span?:string, public jaegerAddress?:string){}
3942
}
43+
4044
export class OpenRawTrace {
4145
constructor(public content?: string) {}
4246
}
47+
4348
export class WorkspaceOnlyChanged {
4449
constructor(public value?: boolean){}
4550
}
51+
4652
export class ErrorViewVisibilityChanged {
4753
constructor(public visible?: boolean){}
4854
}
55+
4956
export class NavigateErrorFlow {
5057
constructor(public offset?: number) {}
5158
}
59+
5260
export class OverlayVisibilityChanged {
5361
constructor(public visible?: boolean, public id?:string){}
5462
}
@@ -87,12 +95,15 @@ export namespace UiMessage
8795
export class SpanList {
8896
constructor(public htmlContent?: string) {}
8997
}
98+
9099
export class ErrorsList {
91100
constructor(public htmlContent?: string) {}
92101
}
102+
93103
export class StackDetails {
94104
constructor(public htmlContent?: string) {}
95105
}
106+
96107
export class CurrenStackInfo {
97108
constructor(public stackInfo?: {
98109
stackNumber: number
@@ -101,12 +112,15 @@ export namespace UiMessage
101112
canNavigateToNext: boolean,
102113
}) {}
103114
}
115+
104116
export class CodeObjectLabel {
105117
constructor(public htmlContent?: string) {}
106118
}
119+
107120
export class SpanObjectLabel {
108121
constructor(public htmlContent?: string) {}
109122
}
123+
110124
export class Overlay {
111125
constructor(public htmlContent?: string, public id?: string) {}
112126
}

‎src/views-ui/codeAnalytics/main.ts‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { consume, publish } from "../common/contracts";
22
import { UiMessage } from "./contracts";
3+
34
window.addEventListener("load", () =>
45
{
56
let overlayVisibility = false;
@@ -88,10 +89,12 @@ window.addEventListener("load", () =>
8889
const errorsTab = $("#view-errors");
8990

9091
consume(UiMessage.Set.Overlay, e => {
91-
if(e.htmlContent)
92+
if(e.htmlContent) {
9293
showOverlay(e.htmlContent, e.id);
93-
else
94+
}
95+
else {
9496
hideOverlay();
97+
}
9598
});
9699

97100
consume(UiMessage.Set.ErrorsList, (event) => {

‎src/views/codeAnalytics/InsightListView/ItemRender/SpanItemRendering.ts‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,17 +96,19 @@ export class SpanItemHtmlRendering{
9696
// <img class="insight-main-image" style="align-self:center;" src="${this._viewUris.image(verb)}" width="8" height="8">
9797
// ${this.getBestUnit(item.previousDuration, item.currentDuration)}, ${item.changeTime.fromNow()}</span>`);
9898
}
99-
else
99+
else {
100100
percentileHtmls.push(/*html*/ `<span></span>`);
101+
}
101102

102-
if(item.changeTime && changeMeaningfulEnough && item.changeVerified === false)
103+
if(item.changeTime && changeMeaningfulEnough && item.changeVerified === false) {
103104
percentileHtmls.push(/*html*/ `<span title="This change is still being validated and is based on initial data.">Evaluating</span>`);
104-
else
105+
}
106+
else {
105107
percentileHtmls.push(/*html*/ `<span></span>`);
108+
}
106109

107110
}
108111

109-
insight.periodicPercentiles
110112
let newHtml = `
111113
<div class="periodic-percentiles-grid">
112114
<div class="grid-header"></div>

‎src/views/codeAnalytics/InsightListView/ItemRender/insightTemplateHtml.ts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,19 @@ export class InsightTemplateHtml
2626
}
2727

2828
public renderHtml():string{
29-
let descriptionHtml = this.data.description
29+
const descriptionHtml = this.data.description
3030
? ` <div class="list-item-content-description">${this.data.description}</div>`
3131
: ``;
3232

33-
let bodyHtml = this.data.body
33+
const bodyHtml = this.data.body
3434
? ` <div class="list-item-body">${this.data.body}</div>`
3535
: ``;
3636

37-
let buttonsHtml = this.data.buttons
37+
const buttonsHtml = this.data.buttons
3838
? ` <div class="list-item-buttons">${this.data.buttons.join("")}</div>`
3939
: ``;
4040

41-
let iconHtml = this.data.icon
41+
const iconHtml = this.data.icon
4242
? `<img class="list-item-icon" src="${this.data.icon}" width="15" height="15">`
4343
: ``;
4444

‎src/views/codeAnalytics/InsightListView/SpanInsight.ts‎

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,24 +55,27 @@ export class SpanUsagesListViewItemsCreator implements IInsightListViewItemsCrea
5555
</span>`;
5656

5757
let lastServiceHtml = '';
58-
if(flow.lastService)
58+
if(flow.lastService) {
5959
lastServiceHtml = /*html*/`
6060
<span class="codicon codicon-arrow-small-right"></span>
6161
<span class="flow-entry ellipsis" title="${flow.lastService.service}: ${flow.lastService.span}">
6262
<span class="flow-service">${flow.lastService.service}:</span>
6363
<span class="flow-span">${flow.lastService.span}</span>
6464
</span>`;
65+
}
6566

6667
let intermediateSpanHtml = '';
6768
let lastServiceSpanHtml = '';
68-
if(flow.intermediateSpan)
69+
if(flow.intermediateSpan) {
6970
intermediateSpanHtml = /*html*/`
7071
<span class="codicon codicon-arrow-small-right"></span>
7172
<span class="ellipsis" title="${flow.intermediateSpan}">${flow.intermediateSpan}</span>`;
72-
else if(flow.lastServiceSpan)
73+
}
74+
else if(flow.lastServiceSpan) {
7375
lastServiceSpanHtml = /*html*/`
7476
<span class="codicon codicon-arrow-small-right"></span>
7577
<span class="ellipsis" title="${flow.lastServiceSpan}">${flow.lastServiceSpan}</span>`;
78+
}
7679

7780
let traceHtml = renderTraceLink(flow.sampleTraceIds?.firstOrDefault(), insight.span);
7881

@@ -390,7 +393,7 @@ export class SpanEndpointBottlenecksListViewItemsCreator implements IInsightList
390393
Percentage of time spent in span:
391394
Median: ${(span.p50.fraction*100).toFixed(0)}% ~${span.p50.maxDuration.value}${span.p50.maxDuration.unit}
392395
P95: ${(span.p95.fraction*100).toFixed(0)}% ~${span.p95.maxDuration.value}${span.p95.maxDuration.unit}
393-
P99: ${(span.p99.fraction*100).toFixed(0)}% ~${span.p99.maxDuration.value}${span.p99.maxDuration.unit}`
396+
P99: ${(span.p99.fraction*100).toFixed(0)}% ~${span.p99.maxDuration.value}${span.p99.maxDuration.unit}`;
394397
}
395398

396399
public async create( codeObjectsInsight: SpandSlowEndpointsInsight[]): Promise<IListViewItem[]> {

‎src/views/codeAnalytics/codeAnalyticsView.ts‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,9 @@ export class CodeAnalyticsView implements vscode.Disposable
104104

105105
vscode.window.onDidChangeTextEditorSelection(
106106
async (e: vscode.TextEditorSelectionChangeEvent) => {
107-
if(e.textEditor.document.languageId !== 'Log')
107+
if(e.textEditor.document.languageId !== 'Log') {
108108
await this._provider.onCodeSelectionChanged(e.textEditor.document, e.selections[0].anchor);
109+
}
109110
}
110111
),
111112
vscode.commands.registerCommand(CodeAnalyticsView.Commands.Show, async (environment:string, codeObjectId: string, codeObjectDisplayName: string) => {
@@ -223,8 +224,9 @@ class CodeAnalyticsViewProvider implements vscode.WebviewViewProvider,vscode.Dis
223224

224225
this._disposables.concat(tabsList);
225226
this._tabs = new Map<string, ICodeAnalyticsViewTab>();
226-
for(let tab of tabsList)
227+
for(let tab of tabsList) {
227228
this._tabs.set(tab.tabId, tab);
229+
}
228230
this._lastActivedTab = tabsList[0];
229231
}
230232

@@ -324,7 +326,7 @@ class CodeAnalyticsViewProvider implements vscode.WebviewViewProvider,vscode.Dis
324326
position: vscode.Position
325327
): Promise<CodeObjectInfo | undefined> {
326328
if(document.uri.scheme !== 'file'){
327-
Logger.error("getCodeObjectOrShowOverlay was called with a non file document! " + document.uri.toString())
329+
Logger.error("getCodeObjectOrShowOverlay was called with a non file document! " + document.uri.toString());
328330
return;
329331
}
330332

0 commit comments

Comments
 (0)