Skip to content

Commit 706423b

Browse files
committed
handling issue when percentiles are not yet ready
1 parent f2395c1 commit 706423b

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

images/waiting-data.png

4.87 KB
Loading

src/views/codeAnalytics/InsightListView/ItemRender/SpanItemRendering.ts

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,26 @@ export class SpanItemHtmlRendering{
2727
}
2828

2929

30+
private getStillCalculatingHtml():string{
31+
return /*html*/ `
32+
<div class="list-item span-durations-insight">
33+
<div class="list-item-content-area">
34+
<div class="list-item-header"><strong>Duration</strong></div>
35+
<div class="list-item-content-description">Waiting for more data.</div>
36+
</div>
37+
38+
<div class="list-item-right-area">
39+
<img class="insight-main-image" style="align-self:center;" src="${this._viewUris.image("waiting-data.png")}" width="32" height="32">
40+
</div>
41+
</div>`;
42+
}
3043
public spanDurationItemHtml(insight: SpanDurationsInsight): string{
3144

3245
const percentileHtmls = [];
3346
const changeHtml = [];
34-
47+
if (insight.percentiles.length===0){
48+
return this.getStillCalculatingHtml();
49+
}
3550
insight.percentiles.sort((a,b) => a.percentile - b.percentile);
3651
for(const item of insight.percentiles){
3752
percentileHtmls.push(/*html*/ `<span>P${item.percentile*100}</span>`);

0 commit comments

Comments
 (0)