Skip to content

Commit aed0143

Browse files
authored
Removed unused CodeObjectId field from SpanHistogramQuery (#248)
1 parent 699dd01 commit aed0143

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/services/analyticsProvider.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ export class AnalyticsProvider {
384384
return response;
385385
}
386386

387-
public async getHtmlGraphForSpanPercentiles(spanName: string, instrumentationLib: string, codeObjectId: string, environment: string, theme?: string): Promise<string> {
387+
public async getHtmlGraphForSpanPercentiles(spanName: string, instrumentationLib: string, environment: string, theme?: string): Promise<string> {
388388
const response: string = await this.sendAndResponseBodyAsString(
389389
'POST',
390390
`/Graphs/graphForSpanPercentiles`,
@@ -394,7 +394,6 @@ export class AnalyticsProvider {
394394
environment: environment,
395395
spanName: spanName,
396396
instrumentationLibrary: instrumentationLib,
397-
codeObjectId: codeObjectId,
398397
theme: theme
399398
});
400399
return response;

src/views/codeAnalytics/Histogram/histogramPanel.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export class HistogramPanel {
77
constructor(private _analyticsProvider: AnalyticsProvider, private _workspaceState: WorkspaceState) {
88
}
99

10-
public async getHtml(spanName: string, instrumentationLibrary: string, codeObjectId: string): Promise<string> {
10+
public async getHtml(spanName: string, instrumentationLibrary: string): Promise<string> {
1111
let theme;
1212
if (vscode.window.activeColorTheme.kind === vscode.ColorThemeKind.Dark){
1313
theme = 'dark';
@@ -16,7 +16,7 @@ export class HistogramPanel {
1616
theme = 'light';
1717
}
1818
const html = await this._analyticsProvider.getHtmlGraphForSpanPercentiles(
19-
spanName, instrumentationLibrary, codeObjectId, this._workspaceState.environment, theme);
19+
spanName, instrumentationLibrary, this._workspaceState.environment, theme);
2020

2121
return html;
2222
}

src/views/codeAnalytics/codeAnalyticsView.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ class CodeAnalyticsViewProvider implements vscode.WebviewViewProvider,vscode.Dis
323323
);
324324

325325
const histogram = new HistogramPanel(this._analyticsProvider, this._workspaceState);
326-
panel.webview.html=await histogram.getHtml(e.span!,e.instrumentationLibrary!,"");
326+
panel.webview.html=await histogram.getHtml(e.span!,e.instrumentationLibrary!);
327327

328328
}
329329

0 commit comments

Comments
 (0)