Fix linter warnings

kshmidt-digma · kshmidt-digma · commit 00b9601eee46 · 2024-12-11T01:34:49.000+01:00
diff --git a/packages/jaeger-ui/src/Contexts.ts b/packages/jaeger-ui/src/Contexts.ts
diff --git a/packages/jaeger-ui/src/ZoomContext.ts b/packages/jaeger-ui/src/ZoomContext.ts
@@ -0,0 +1,6 @@
+import { createContext } from 'react';
+import ZoomManager from './utils/ZoomManager';
+
+const ZoomContext = createContext<null | ZoomManager>(null);
+
+export default ZoomContext;
diff --git a/packages/jaeger-ui/src/api/digma/actions.ts b/packages/jaeger-ui/src/api/digma/actions.ts
@@ -1,4 +1,4 @@
-import { addActionPrefix } from './addActionPrefix';
+import addActionPrefix from './addActionPrefix';
 
 export const actions = {
   GO_TO_SPAN: 'GO_TO_SPAN',
diff --git a/packages/jaeger-ui/src/api/digma/addActionPrefix.ts b/packages/jaeger-ui/src/api/digma/addActionPrefix.ts
@@ -1,8 +1,8 @@
-import { isString } from '../../utils/ts/typeGuards/isString';
+import isString from '../../utils/ts/typeGuards/isString';
 
 type PrefixedMap<T> = Record<keyof T, string>;
 
-export const addActionPrefix = <T extends Record<string, string>>(
+const addActionPrefix = <T extends Record<string, string>>(
   prefix: string,
   actions: T,
   separator?: string
@@ -17,3 +17,5 @@ export const addActionPrefix = <T extends Record<string, string>>(
 
   return res;
 };
+
+export default addActionPrefix;
diff --git a/packages/jaeger-ui/src/api/digma/index.ts b/packages/jaeger-ui/src/api/digma/index.ts
@@ -1,5 +1,5 @@
 import logger from '../../logging';
-import { isObject } from '../../utils/ts/typeGuards/isObject';
+import isObject from '../../utils/ts/typeGuards/isObject';
 import ActionDispatcher from './ActionDispatcher';
 import { updateState } from './state';
 import { DigmaMessageEvent, IDigmaOutgoingMessageData } from './types';
@@ -24,7 +24,7 @@ export const initializeDigmaMessageListener = (dispatcher: ActionDispatcher) =>
 
       updateState(e.data.action, e.data.payload);
 
-      dispatcher.dispatch(e.timeStamp, e.data.action, e.data.payload);
+      dispatcher.dispatch(e.timeStamp, e.data.action, e.data.payload, e.data.error);
     }
   };
 
diff --git a/packages/jaeger-ui/src/api/jaeger.js b/packages/jaeger-ui/src/api/jaeger.js
@@ -17,7 +17,7 @@ import moment from 'moment';
 import queryString from 'query-string';
 
 import prefixUrl from '../utils/prefix-url';
-import { isString } from '../utils/ts/typeGuards/isString';
+import isString from '../utils/ts/typeGuards/isString';
 
 // export for tests
 export function getMessageFromError(errData, status) {
diff --git a/packages/jaeger-ui/src/components/App/index.jsx b/packages/jaeger-ui/src/components/App/index.jsx
@@ -38,9 +38,9 @@ import JaegerAPI, { DEFAULT_API_ROOT } from '../../api/jaeger';
 import configureStore from '../../utils/configure-store';
 import processScripts from '../../utils/config/process-scripts';
 import prefixUrl from '../../utils/prefix-url';
-import { isString } from '../../utils/ts/typeGuards/isString';
+import isString from '../../utils/ts/typeGuards/isString';
 import ZoomManager from '../../utils/ZoomManager';
-import { ZoomContext } from '../../Contexts';
+import ZoomContext from '../../ZoomContext';
 
 import '../common/vars.css';
 import '../common/utils.css';
diff --git a/packages/jaeger-ui/src/components/Monitor/EmptyState/index.tsx b/packages/jaeger-ui/src/components/Monitor/EmptyState/index.tsx
@@ -17,7 +17,7 @@ import { Row, Col, Button, Alert } from 'antd';
 import './index.css';
 import { MonitorEmptyStateConfig } from '../../../types/config';
 import { getConfigValue } from '../../../utils/config/get-config';
-import { getStaticAssetPath } from '../../../utils/getStaticAssetPath';
+import getStaticAssetPath from '../../../utils/getStaticAssetPath';
 import monitorImg from './media/monitor.png';
 
 const monitorImgUrl = getStaticAssetPath(monitorImg);
diff --git a/packages/jaeger-ui/src/components/SearchTracePage/index.jsx b/packages/jaeger-ui/src/components/SearchTracePage/index.jsx
@@ -34,7 +34,7 @@ import { actions as traceDiffActions } from '../TraceDiff/duck';
 import { fetchedState } from '../../constants';
 import { sortTraces } from '../../model/search';
 import { stripEmbeddedState } from '../../utils/embedded-url';
-import { getStaticAssetPath } from '../../utils/getStaticAssetPath';
+import getStaticAssetPath from '../../utils/getStaticAssetPath';
 import FileLoader from './FileLoader';
 
 import './index.css';
diff --git a/packages/jaeger-ui/src/components/TracePage/TracePageHeader/ZoomControls.tsx b/packages/jaeger-ui/src/components/TracePage/TracePageHeader/ZoomControls.tsx
@@ -1,7 +1,7 @@
 import { Button } from 'antd';
 import React, { useContext } from 'react';
 import ButtonGroup from 'antd/lib/button/button-group';
-import { ZoomContext } from '../../../Contexts';
+import ZoomContext from '../../../ZoomContext';
 
 type ZoomControlsProps = {
   className?: string;
diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanBarRow.tsx
@@ -28,7 +28,7 @@ import dispatcher from '../../../api/digma/dispatcher';
 import { actions } from '../../../api/digma/actions';
 import { state as globalState } from '../../../api/digma/state';
 import { ISpanInsight, SetSpansDataPayload } from '../../../api/digma/types';
-import { LightBulbIcon } from '../../common/icons/LightBulbIcon';
+import LightBulbIcon from '../../common/icons/LightBulbIcon';
 import { getInsightImportanceColor } from '../../common/InsightIcon/utils';
 
 import { TNil } from '../../../types';
diff --git a/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx b/packages/jaeger-ui/src/components/TracePage/TraceTimelineViewer/SpanDetail/index.tsx
@@ -34,9 +34,9 @@ import {
   SetSpansDataPayload,
 } from '../../../../api/digma/types';
 import { getInsightTypeInfo, getInsightTypeOrderPriority } from '../../../common/InsightIcon/utils';
-import { InsightIcon } from '../../../common/InsightIcon';
+import InsightIcon from '../../../common/InsightIcon';
 import Button from '../../../common/Button';
-import { CrosshairIcon } from '../../../common/icons/CrosshairIcon';
+import CrosshairIcon from '../../../common/icons/CrosshairIcon';
 import getSpanDataForDigma from '../../../../utils/getSpanDataForDigma';
 
 import { TNil } from '../../../../types';
diff --git a/packages/jaeger-ui/src/components/common/ErrorMessage.tsx b/packages/jaeger-ui/src/components/common/ErrorMessage.tsx
@@ -17,10 +17,10 @@ import * as React from 'react';
 import { ApiError } from '../../types/api-error';
 
 import './ErrorMessage.css';
-import { CrossedCrosshairCircleIcon } from './icons/CrossedCrosshairCircleIcon';
-import { SlackLogoIcon } from './icons/SlackLogoIcon';
-import { BrokenLinkCircleIcon } from './icons/BrokenLinkCircleIcon';
-import { isString } from '../../utils/ts/typeGuards/isString';
+import CrossedCrosshairCircleIcon from './icons/CrossedCrosshairCircleIcon';
+import SlackLogoIcon from './icons/SlackLogoIcon';
+import BrokenLinkCircleIcon from './icons/BrokenLinkCircleIcon';
+import isString from '../../utils/ts/typeGuards/isString';
 
 const SLACK_CHANNEL_URL =
   'https://join.slack.com/t/continuous-feedback/shared_invite/zt-2gsif7wdy-6Jf17HIJESc2tknT5gybtw';
diff --git a/packages/jaeger-ui/src/components/common/InsightIcon/index.tsx b/packages/jaeger-ui/src/components/common/InsightIcon/index.tsx
@@ -2,9 +2,11 @@ import * as React from 'react';
 import { IInsightIconProps } from './types';
 import { getInsightImportanceColor, getInsightTypeInfo } from './utils';
 
-export const InsightIcon = (props: IInsightIconProps) => {
+const InsightIcon = (props: IInsightIconProps) => {
   const insightTypeInfo = getInsightTypeInfo(props.insight.type);
   return insightTypeInfo ? (
     <insightTypeInfo.icon color={getInsightImportanceColor(props.insight.importance)} size={props.size} />
   ) : null;
 };
+
+export default InsightIcon;
diff --git a/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts b/packages/jaeger-ui/src/components/common/InsightIcon/utils.ts
@@ -1,19 +1,19 @@
 import * as React from 'react';
-import { AlarmClockIcon } from '../icons/AlarmClockIcon';
-import { BottleneckIcon } from '../icons/BottleneckIcon';
-import { MeterHighIcon } from '../icons/MeterHighIcon';
-import { MeterLowIcon } from '../icons/MeterLowIcon';
-import { MeterMediumIcon } from '../icons/MeterMediumIcon';
-import { SQLDatabaseIcon } from '../icons/SQLDatabaseIcon';
-import { ScalesIcon } from '../icons/ScalesIcon';
-import { SineIcon } from '../icons/SineIcon';
-import { SnailIcon } from '../icons/SnailIcon';
-import { SpotIcon } from '../icons/SpotIcon';
-import { WarningCircleIcon } from '../icons/WarningCircleIcon';
+import AlarmClockIcon from '../icons/AlarmClockIcon';
+import BottleneckIcon from '../icons/BottleneckIcon';
+import MeterHighIcon from '../icons/MeterHighIcon';
+import MeterLowIcon from '../icons/MeterLowIcon';
+import MeterMediumIcon from '../icons/MeterMediumIcon';
+import SQLDatabaseIcon from '../icons/SQLDatabaseIcon';
+import ScalesIcon from '../icons/ScalesIcon';
+import SineIcon from '../icons/SineIcon';
+import SnailIcon from '../icons/SnailIcon';
+import SpotIcon from '../icons/SpotIcon';
+import WarningCircleIcon from '../icons/WarningCircleIcon';
 import { IIconProps } from '../icons/types';
 import { InsightType } from './types';
-import { ClockWithTicksIcon } from '../icons/ClockWithTicksIcon';
-import { PieChartIcon } from '../icons/PieChartIcon';
+import ClockWithTicksIcon from '../icons/ClockWithTicksIcon';
+import PieChartIcon from '../icons/PieChartIcon';
 
 export const getInsightTypeInfo = (
   type: InsightType
diff --git a/packages/jaeger-ui/src/components/common/icons/AlarmClockIcon.tsx b/packages/jaeger-ui/src/components/common/icons/AlarmClockIcon.tsx
@@ -17,4 +17,6 @@ const AlarmClockIconComponent = (props: IIconProps) => {
   );
 };
 
-export const AlarmClockIcon = React.memo(AlarmClockIconComponent);
+const AlarmClockIcon = React.memo(AlarmClockIconComponent);
+
+export default AlarmClockIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/BottleneckIcon.tsx b/packages/jaeger-ui/src/components/common/icons/BottleneckIcon.tsx
@@ -16,4 +16,6 @@ const BottleneckIconComponent = (props: IIconProps) => {
   );
 };
 
-export const BottleneckIcon = React.memo(BottleneckIconComponent);
+const BottleneckIcon = React.memo(BottleneckIconComponent);
+
+export default BottleneckIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/BrokenLinkCircleIcon.tsx b/packages/jaeger-ui/src/components/common/icons/BrokenLinkCircleIcon.tsx
@@ -16,4 +16,6 @@ const BrokenLinkCircleIconComponent = (props: IIconProps) => {
   );
 };
 
-export const BrokenLinkCircleIcon = React.memo(BrokenLinkCircleIconComponent);
+const BrokenLinkCircleIcon = React.memo(BrokenLinkCircleIconComponent);
+
+export default BrokenLinkCircleIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/ClockWithTicksIcon.tsx b/packages/jaeger-ui/src/components/common/icons/ClockWithTicksIcon.tsx
@@ -15,4 +15,6 @@ const ClockWithTicksIconComponent = (props: IIconProps) => {
   );
 };
 
-export const ClockWithTicksIcon = React.memo(ClockWithTicksIconComponent);
+const ClockWithTicksIcon = React.memo(ClockWithTicksIconComponent);
+
+export default ClockWithTicksIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/CrossedCrosshairCircleIcon.tsx b/packages/jaeger-ui/src/components/common/icons/CrossedCrosshairCircleIcon.tsx
@@ -20,4 +20,6 @@ const CrossedCrosshairCircleIconComponent = (props: IIconProps) => {
   );
 };
 
-export const CrossedCrosshairCircleIcon = React.memo(CrossedCrosshairCircleIconComponent);
+const CrossedCrosshairCircleIcon = React.memo(CrossedCrosshairCircleIconComponent);
+
+export default CrossedCrosshairCircleIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/CrosshairIcon.tsx b/packages/jaeger-ui/src/components/common/icons/CrosshairIcon.tsx
@@ -17,4 +17,6 @@ const CrosshairIconComponent = (props: IIconProps) => {
   );
 };
 
-export const CrosshairIcon = React.memo(CrosshairIconComponent);
+const CrosshairIcon = React.memo(CrosshairIconComponent);
+
+export default CrosshairIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/LightBulbIcon.tsx b/packages/jaeger-ui/src/components/common/icons/LightBulbIcon.tsx
@@ -23,4 +23,6 @@ const LightBulbIconComponent = (props: IIconProps) => {
   );
 };
 
-export const LightBulbIcon = React.memo(LightBulbIconComponent);
+const LightBulbIcon = React.memo(LightBulbIconComponent);
+
+export default LightBulbIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/MeterHighIcon.tsx b/packages/jaeger-ui/src/components/common/icons/MeterHighIcon.tsx
@@ -25,4 +25,6 @@ const MeterHighIconComponent = (props: IIconProps) => {
   );
 };
 
-export const MeterHighIcon = React.memo(MeterHighIconComponent);
+const MeterHighIcon = React.memo(MeterHighIconComponent);
+
+export default MeterHighIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/MeterLowIcon.tsx b/packages/jaeger-ui/src/components/common/icons/MeterLowIcon.tsx
@@ -25,4 +25,6 @@ const MeterLowIconComponent = (props: IIconProps) => {
   );
 };
 
-export const MeterLowIcon = React.memo(MeterLowIconComponent);
+const MeterLowIcon = React.memo(MeterLowIconComponent);
+
+export default MeterLowIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/MeterMediumIcon.tsx b/packages/jaeger-ui/src/components/common/icons/MeterMediumIcon.tsx
@@ -25,4 +25,6 @@ const MeterMediumIconComponent = (props: IIconProps) => {
   );
 };
 
-export const MeterMediumIcon = React.memo(MeterMediumIconComponent);
+const MeterMediumIcon = React.memo(MeterMediumIconComponent);
+
+export default MeterMediumIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/PieChartIcon.tsx b/packages/jaeger-ui/src/components/common/icons/PieChartIcon.tsx
@@ -15,4 +15,6 @@ const PieChartIconComponent = (props: IIconProps) => {
   );
 };
 
-export const PieChartIcon = React.memo(PieChartIconComponent);
+const PieChartIcon = React.memo(PieChartIconComponent);
+
+export default PieChartIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/SQLDatabaseIcon.tsx b/packages/jaeger-ui/src/components/common/icons/SQLDatabaseIcon.tsx
@@ -17,4 +17,6 @@ const SQLDatabaseIconComponent = (props: IIconProps) => {
   );
 };
 
-export const SQLDatabaseIcon = React.memo(SQLDatabaseIconComponent);
+const SQLDatabaseIcon = React.memo(SQLDatabaseIconComponent);
+
+export default SQLDatabaseIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/ScalesIcon.tsx b/packages/jaeger-ui/src/components/common/icons/ScalesIcon.tsx
@@ -17,4 +17,6 @@ const ScalesIconComponent = (props: IIconProps) => {
   );
 };
 
-export const ScalesIcon = React.memo(ScalesIconComponent);
+const ScalesIcon = React.memo(ScalesIconComponent);
+
+export default ScalesIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/SineIcon.tsx b/packages/jaeger-ui/src/components/common/icons/SineIcon.tsx
@@ -12,4 +12,6 @@ const SineIconComponent = (props: IIconProps) => {
   );
 };
 
-export const SineIcon = React.memo(SineIconComponent);
+const SineIcon = React.memo(SineIconComponent);
+
+export default SineIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/SlackLogoIcon.tsx b/packages/jaeger-ui/src/components/common/icons/SlackLogoIcon.tsx
@@ -34,4 +34,6 @@ const SlackLogoIconComponent = (props: IIconProps) => {
   );
 };
 
-export const SlackLogoIcon = React.memo(SlackLogoIconComponent);
+const SlackLogoIcon = React.memo(SlackLogoIconComponent);
+
+export default SlackLogoIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/SnailIcon.tsx b/packages/jaeger-ui/src/components/common/icons/SnailIcon.tsx
@@ -21,4 +21,6 @@ const SnailIconComponent = (props: IIconProps) => {
   );
 };
 
-export const SnailIcon = React.memo(SnailIconComponent);
+const SnailIcon = React.memo(SnailIconComponent);
+
+export default SnailIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/SpotIcon.tsx b/packages/jaeger-ui/src/components/common/icons/SpotIcon.tsx
@@ -17,4 +17,6 @@ const SpotIconComponent = (props: IIconProps) => {
   );
 };
 
-export const SpotIcon = React.memo(SpotIconComponent);
+const SpotIcon = React.memo(SpotIconComponent);
+
+export default SpotIcon;
diff --git a/packages/jaeger-ui/src/components/common/icons/WarningCircleIcon.tsx b/packages/jaeger-ui/src/components/common/icons/WarningCircleIcon.tsx
@@ -18,4 +18,6 @@ const WarningCircleIconComponent = (props: IIconProps) => {
   );
 };
 
-export const WarningCircleIcon = React.memo(WarningCircleIconComponent);
+const WarningCircleIcon = React.memo(WarningCircleIconComponent);
+
+export default WarningCircleIcon;
diff --git a/packages/jaeger-ui/src/logging/Logger.ts b/packages/jaeger-ui/src/logging/Logger.ts
@@ -1,5 +1,5 @@
 import moment from 'moment';
-import { LOG_LEVEL } from './types';
+import LOG_LEVEL from './types';
 
 class Logger {
   private minLogLevel: number;
diff --git a/packages/jaeger-ui/src/logging/index.ts b/packages/jaeger-ui/src/logging/index.ts
@@ -1,5 +1,5 @@
 import Logger from './Logger';
-import { LOG_LEVEL } from './types';
+import LOG_LEVEL from './types';
 
 const logger = new Logger(window.isLoggingEnabled === true ? LOG_LEVEL.DEBUG : LOG_LEVEL.NONE);
 
diff --git a/packages/jaeger-ui/src/logging/types.ts b/packages/jaeger-ui/src/logging/types.ts
@@ -1,7 +1,9 @@
-export enum LOG_LEVEL {
+enum LOG_LEVEL {
   DEBUG = 0,
   INFO = 1,
   WARN = 2,
   ERROR = 3,
   NONE = 4,
 }
+
+export default LOG_LEVEL;
diff --git a/packages/jaeger-ui/src/platform.ts b/packages/jaeger-ui/src/platform.ts
@@ -1,4 +1,4 @@
-import { isString } from './utils/ts/typeGuards/isString';
+import isString from './utils/ts/typeGuards/isString';
 
 type Platform = 'JetBrains' | 'VS Code' | 'Web';
 
diff --git a/packages/jaeger-ui/src/utils/getStaticAssetPath.ts b/packages/jaeger-ui/src/utils/getStaticAssetPath.ts
@@ -1,4 +1,6 @@
-import { isString } from './ts/typeGuards/isString';
+import isString from './ts/typeGuards/isString';
 
-export const getStaticAssetPath = (path: string) =>
+const getStaticAssetPath = (path: string) =>
   isString(window.staticPath) ? new URL(path, window.staticPath).href : path;
+
+export default getStaticAssetPath;
diff --git a/packages/jaeger-ui/src/utils/ts/typeGuards/isNull.ts b/packages/jaeger-ui/src/utils/ts/typeGuards/isNull.ts
@@ -1 +1,3 @@
-export const isNull = (x: unknown): x is null => x === null;
+const isNull = (x: unknown): x is null => x === null;
+
+export default isNull;
diff --git a/packages/jaeger-ui/src/utils/ts/typeGuards/isObject.ts b/packages/jaeger-ui/src/utils/ts/typeGuards/isObject.ts
@@ -1,3 +1,5 @@
-import { isNull } from './isNull';
+import isNull from './isNull';
 
-export const isObject = (x: unknown): x is Record<string, unknown> => typeof x === 'object' && !isNull(x);
+const isObject = (x: unknown): x is Record<string, unknown> => typeof x === 'object' && !isNull(x);
+
+export default isObject;
diff --git a/packages/jaeger-ui/src/utils/ts/typeGuards/isString.ts b/packages/jaeger-ui/src/utils/ts/typeGuards/isString.ts
@@ -1 +1,3 @@
-export const isString = (x: unknown): x is string => typeof x === 'string';
+const isString = (x: unknown): x is string => typeof x === 'string';
+
+export default isString;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { addActionPrefix } from './addActionPrefix';`
	`1`	`+import addActionPrefix from './addActionPrefix';`
`2`	`2`
`3`	`3`	`export const actions = {`
`4`	`4`	`GO_TO_SPAN: 'GO_TO_SPAN',`