Skip to content

Commit cfe765d

Browse files
Merge pull request #60 from digma-ai/fix/base-url
Add baseUrl variable
2 parents 23b04e9 + 7ba1e36 commit cfe765d

File tree

5 files changed

+41
-33
lines changed

5 files changed

+41
-33
lines changed

packages/jaeger-ui/index.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
window.global = {};
4040
</script>
4141
<script>
42+
window.baseUrl;
4243
window.apiBaseUrl;
4344
window.initialRoutePath;
4445
window.embeddedMode;

packages/jaeger-ui/src/components/TracePage/TracePageHeader/AltViewOptions.tsx

Lines changed: 33 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -71,37 +71,41 @@ export default function AltViewOptions(props: Props) {
7171
onTraceViewChange(item);
7272
};
7373

74-
const menu = (
75-
<Menu>
76-
{MENU_ITEMS.filter(item => item.viewType !== viewType).map(item => (
77-
<Menu.Item key={item.viewType}>
78-
<a onClick={() => handleSelectView(item.viewType)} role="button">
79-
{item.label}
74+
const menu = () => {
75+
const baseUrl = window.baseUrl ?? window.apiBaseUrl;
76+
77+
return (
78+
<Menu>
79+
{MENU_ITEMS.filter(item => item.viewType !== viewType).map(item => (
80+
<Menu.Item key={item.viewType}>
81+
<a onClick={() => handleSelectView(item.viewType)} role="button">
82+
{item.label}
83+
</a>
84+
</Menu.Item>
85+
))}
86+
<Menu.Item>
87+
<a
88+
href={`${baseUrl}/api/traces/${traceID}?prettyPrint=true`}
89+
rel="noopener noreferrer"
90+
target="_blank"
91+
onClick={trackJsonView}
92+
>
93+
Trace JSON
8094
</a>
8195
</Menu.Item>
82-
))}
83-
<Menu.Item>
84-
<a
85-
href={`${window.apiBaseUrl}/api/traces/${traceID}?prettyPrint=true`}
86-
rel="noopener noreferrer"
87-
target="_blank"
88-
onClick={trackJsonView}
89-
>
90-
Trace JSON
91-
</a>
92-
</Menu.Item>
93-
<Menu.Item>
94-
<a
95-
href={`${window.apiBaseUrl}/api/traces/${traceID}?raw=true&prettyPrint=true`}
96-
rel="noopener noreferrer"
97-
target="_blank"
98-
onClick={trackRawJsonView}
99-
>
100-
Trace JSON (unadjusted)
101-
</a>
102-
</Menu.Item>
103-
</Menu>
104-
);
96+
<Menu.Item>
97+
<a
98+
href={`${baseUrl}/api/traces/${traceID}?raw=true&prettyPrint=true`}
99+
rel="noopener noreferrer"
100+
target="_blank"
101+
onClick={trackRawJsonView}
102+
>
103+
Trace JSON (unadjusted)
104+
</a>
105+
</Menu.Item>
106+
</Menu>
107+
);
108+
};
105109

106110
const currentItem = MENU_ITEMS.find(item => item.viewType === viewType);
107111
const dropdownText = currentItem ? currentItem.label : 'Alternate Views';

packages/jaeger-ui/src/components/TracePage/TracePageHeader/TracePageHeader.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,11 +159,12 @@ export function TracePageHeaderFn(props: TracePageHeaderEmbedProps & { forwarded
159159
);
160160

161161
const handleStandaloneLinkClick = (e: React.MouseEvent<HTMLAnchorElement>) => {
162+
const baseUrl = window.baseUrl ?? window.apiBaseUrl;
162163
e.preventDefault();
163164
window.sendMessageToDigma<OpenURLInDefaultBrowserPayload>({
164165
action: globalActions.OPEN_URL_IN_DEFAULT_BROWSER,
165166
payload: {
166-
url: `${window.apiBaseUrl}${window.location.pathname}${window.location.search}`,
167+
url: `${baseUrl}${window.location.pathname}${window.location.search}`,
167168
},
168169
});
169170
};

packages/jaeger-ui/src/components/common/ErrorMessage.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ export default function ErrorMessage({
164164
}
165165

166166
if (error.message.includes('Failed to fetch') || error.httpStatus === 502) {
167+
const baseUrl = window.baseUrl ?? window.apiBaseUrl;
167168
const isUserDefinedJaegerQueryURL = window.isUserDefinedJaegerQueryURL === true;
168169
return (
169170
<DigmaErrorMessage
@@ -173,16 +174,16 @@ export default function ErrorMessage({
173174
isUserDefinedJaegerQueryURL ? (
174175
<>
175176
The Jaeger link
176-
{isString(window.apiBaseUrl) && (
177+
{isString(baseUrl) && (
177178
<>
178179
{' '}
179180
<a
180181
className="CustomErrorMessage--link"
181-
href={window.apiBaseUrl}
182+
href={baseUrl}
182183
target="_blank"
183184
rel="noopener noreferrer"
184185
>
185-
{window.apiBaseUrl}
186+
{baseUrl}
186187
</a>
187188
</>
188189
)}{' '}

packages/jaeger-ui/typings/custom.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ declare interface Window {
3636
) => string | undefined;
3737
cancelMessageToDigma: (request_id: string) => void;
3838
platform?: unknown;
39+
baseUrl?: unknown
3940
apiBaseUrl?: unknown;
4041
initialRoutePath?: unknown;
4142
embeddedMode?: unknown;

0 commit comments

Comments
 (0)