Fix issue with package-internal function that needed to be tested but

caused circular imports.

Author: dillonkearns

examples/end-to-end/script/src/FileTests.elm

@@ -86,11 +86,11 @@ runTests =
         , test "absolute detection handles POSIX, UNC, and Windows" <|
             \() ->
                 Expect.all
-                    [ \_ -> Expect.equal True (FilePath.fromString "/foo" |> FilePath.Internal.isAbsolute)
-                    , \_ -> Expect.equal True (FilePath.fromString "//server/share" |> FilePath.Internal.isAbsolute)
-                    , \_ -> Expect.equal True (FilePath.fromString "C:/foo" |> FilePath.Internal.isAbsolute)
-                    , \_ -> Expect.equal False (FilePath.fromString "C:foo" |> FilePath.Internal.isAbsolute)
-                    , \_ -> Expect.equal False (FilePath.fromString "../foo" |> FilePath.Internal.isAbsolute)
+                    [ \_ -> Expect.equal True (FilePath.fromString "/foo" |> FilePath.toString |> FilePath.Internal.isAbsolute)
+                    , \_ -> Expect.equal True (FilePath.fromString "//server/share" |> FilePath.toString |> FilePath.Internal.isAbsolute)
+                    , \_ -> Expect.equal True (FilePath.fromString "C:/foo" |> FilePath.toString |> FilePath.Internal.isAbsolute)
+                    , \_ -> Expect.equal False (FilePath.fromString "C:foo" |> FilePath.toString |> FilePath.Internal.isAbsolute)
+                    , \_ -> Expect.equal False (FilePath.fromString "../foo" |> FilePath.toString |> FilePath.Internal.isAbsolute)
                     ]
                     ()
                     |> BackendTask.succeed

src/FilePath.elm

@@ -37,6 +37,7 @@ import BackendTask.Http
 import BackendTask.Internal.Request
 import Char
 import FatalError exposing (FatalError)
+import FilePath.Internal
 import Json.Decode as Decode
 import Json.Encode as Encode
 
@@ -151,7 +152,7 @@ append basePath nextPath =
                 { root = baseParsed.root
                 , pathSegments =
                     normalizePathSegments
-                        (isAbsoluteRoot baseParsed.root)
+                        (FilePath.Internal.isAbsolute baseParsed.root)
                         (baseParsed.pathSegments ++ nextParsed.pathSegments)
                 }
             )
@@ -319,22 +320,10 @@ parse (FilePath rawPath) =
     , pathSegments =
         withoutRoot
             |> String.split "/"
-            |> normalizePathSegments (isAbsoluteRoot root)
+            |> normalizePathSegments (FilePath.Internal.isAbsolute root)
     }
 
 
-isAbsoluteRoot : String -> Bool
-isAbsoluteRoot root =
-    case root of
-        "/" ->
-            True
-
-        "//" ->
-            True
-
-        _ ->
-            String.endsWith ":/" root
-
 
 normalizePathSegments : Bool -> List String -> List String
 normalizePathSegments hasAbsoluteRoot rawSegments =

src/FilePath/Internal.elm

@@ -1,26 +1,20 @@
 module FilePath.Internal exposing (isAbsolute)
 
 import Char
-import FilePath exposing (FilePath)
 
 
-{-| Whether this path is absolute. Package-internal only — not exposed to consumers.
+{-| Whether a path string represents an absolute path. Package-internal only — not
+exposed to consumers.
 
-Checks the normalized string prefix, which is equivalent to checking the parsed root
-since `FilePath.fromString` guarantees consistent formatting:
+Works on the normalized string form produced by `FilePath.toString`:
 
   - `/...` → POSIX absolute
   - `//...` → UNC absolute
   - `X:/...` → Windows drive absolute
 
 -}
-isAbsolute : FilePath -> Bool
-isAbsolute filePath =
-    let
-        str : String
-        str =
-            FilePath.toString filePath
-    in
+isAbsolute : String -> Bool
+isAbsolute str =
     String.startsWith "/" str
         || hasAbsoluteDriveRoot str