Skip to content

Commit ef2419e

Browse files
author
Hugo Osvaldo Barrera
committed
Avoid running bogus tests with Fastmail
The fix that disabled VTODO tests accidentally ran all other tests twice for this storage. This wasn't picked up earlier since Fastmail is not currently running on CI.
1 parent 2eff8e0 commit ef2419e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/storage/servers/fastmail/__init__.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@
55

66
class ServerMixin:
77
@pytest.fixture
8-
def get_storage_args(self, item_type, slow_create_collection, aio_connector):
9-
if item_type == "VTODO":
10-
# Fastmail has non-standard support for TODOs
11-
# See https://github.com/pimutils/vdirsyncer/issues/824
12-
pytest.skip("Fastmail has non-standard VTODO support.")
8+
def get_storage_args(self, slow_create_collection, aio_connector, request):
9+
if "item_type" in request.fixturenames:
10+
if request.getfixturevalue("item_type") == "VTODO":
11+
# Fastmail has non-standard support for TODOs
12+
# See https://github.com/pimutils/vdirsyncer/issues/824
13+
pytest.skip("Fastmail has non-standard VTODO support.")
1314

1415
async def inner(collection="test"):
1516
args = {

0 commit comments

Comments
 (0)