dry code better

Author: shubham1g5

app/src/org/commcare/location/CommCareLocationController.kt

@@ -33,26 +33,21 @@ fun isLocationFresh(location: Location, maxAgeMs: Long = DEFAULT_TIME_THRESHOLD)
 
 fun shouldDiscardLocation(location: Location): Boolean {
     if(!isLocationFresh(location)) {
-        Logger.exception(
-            "Received a stale location",
-            Exception(
-                "Received a stale location with accuracy ${location.accuracy}"  +
-                    " with time ${location.time}" + " and current device time ${System.currentTimeMillis()}"
-            )
-        )
+        Logger.exception("Received a stale location", getStaleLocationException(location))
         return HiddenPreferences.shouldDiscardStaleLocations()
     }
     return false
 }
 
+fun getStaleLocationException(location: Location): Throwable {
+    Exception(
+        "Stale location with accuracy ${location.accuracy}"  +
+            " with time ${location.time}" + " and current device time ${System.currentTimeMillis()}"
+    )
+}
+
 fun logStaleLocationSaved(location: Location) {
     if (!isLocationFresh(location, DEFAULT_TIME_THRESHOLD)) {
-        Logger.exception(
-            "Stale location saved in GPS capture",
-            Throwable(
-                "Saved a stale location with accuracy ${location.accuracy}" +
-                    " with time ${location.time}" + " and current device time ${System.currentTimeMillis()}"
-            )
-        )
+        Logger.exception("Stale location saved in GPS capture", getStaleLocationException(location))
     }
 }