req.(connection|socket).remotePort is not supported

[jimmyolo]

server listen on unix_socket, if access the req.ip,
will throw the RangeError: Offset is outside the bounds of the DataView. due to req.rawIp is an empty ArrayBuffer(0)

RangeError: Offset is outside the bounds of the DataView
    at DataView.prototype.getUint16 (<anonymous>)
    at get parsedIp (/home/jimmy/Projects/playground/node_modules/ultimate-express/src/request.js:259:26)
    at get ip (/home/jimmy/Projects/playground/node_modules/ultimate-express/src/request.js:174:25)
    at /home/jimmy/Projects/playground/unix_socket/index.js:14:19
    at next (/home/jimmy/Projects/playground/node_modules/ultimate-express/src/router.js:543:37)
    at /home/jimmy/Projects/playground/node_modules/ultimate-express/src/router.js:564:17
    at new Promise (<anonymous>)

const express = require('ultimate-express')

const { fetch, Agent } = require('undici');
const http = require('node:http');

const app = express();

app.get('/test', (req, res) => {
  res.send('Hello, World!');
});

app.listen('/tmp/app.sock', (t) => {
  console.log('Server is running on Unix socket', t);
})

// fetch('http://localhost/test', {
//   dispatcher: new Agent({
//     connect: {
//       socketPath: '/tmp/app.sock'
//     }
//   })
// }).then(async (resp) => {
//   console.log(await resp.text())
// })


http.request({
  socketPath: '/tmp/app.sock',
  path: '/test',
}, (res) => {
  res.on('data', (data) => {
    console.log(data.toString());
  });
}).end();

• req.(connection|socket).remotePort is wrong
  

  ultimate-express/src/request.js

  Lines 272 to 273 in 86c6798

  	localPort: this.app.port,
  	remotePort: this.app.port,

[dimdenGD]

What are expected returns for req.ip and remotePort on unix socket?

[jimmyolo]

from my test, req.ip is undefined in express.
(req.ips is an empty array, (remote|local)(Address|Port) are undefined)

regarding the remotePort, is wrong via the normal TCP socket port.

[jimmyolo]

I guess we need upstream to expose the functionality
https://github.com/uNetworking/uSockets/blob/182b7e4fe7211f98682772be3df89c71dc4884fa/src/socket.c#L37

https://github.com/uNetworking/uWebSockets.js/blob/14bb3af6789a263804899d5440223b9e2a5a43e3/src/addon.cpp#L421-L423

[jimmyolo]

or when rawIp = _res.getRemoteAddress() is empty arraybuffer, (means connect via unix_socket?)

[dimdenGD]

Published fix for IP erroring and removed remotePort being shown as supported. Will have to wait for uWS to add remote port binding. I would recommend you just making the PR instead of asking them, because they often don't reply to issues so it could take months/years.