fix: resolve CI lint, formatting, and cargo-shear failures

- Remove unused `parking_lot` dependency (cargo-shear)
- Add `[lints] workspace = true` to dimos/Cargo.toml (rerun lint)
- Fix TOML formatting in dimos/pyproject.toml (taplo)
- Rename error variables from `e` to `err` (rerun lint convention)
- Fix trailing whitespace in keyboard.rs
- Add blank lines before doc comments on struct fields/constants
- Use Display instead of Debug for error formatting in viewer.rs
- Commit updated Cargo.lock

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: jeff-hykin

Cargo.lock

@@ -3110,12 +3110,11 @@ dependencies = [
 
 [[package]]
 name = "dimos-viewer"
-version = "0.30.0-alpha.1+dev"
+version = "0.30.0-alpha.4"
 dependencies = [
  "bincode",
  "clap",
  "mimalloc",
- "parking_lot",
  "rerun",
  "serde",
  "tokio",

dimos/Cargo.toml

@@ -29,7 +29,6 @@ rerun = { path = "../crates/top/rerun", default-features = false, features = [
 clap = { workspace = true, features = ["derive"] }
 bincode.workspace = true
 mimalloc.workspace = true
-parking_lot.workspace = true
 serde = { workspace = true, features = ["derive"] }
 tokio = { workspace = true, features = [
   "io-util",
@@ -40,3 +39,6 @@ tokio = { workspace = true, features = [
   "sync",
   "time",
 ] }
+
+[lints]
+workspace = true

dimos/pyproject.toml

@@ -8,18 +8,18 @@ version = "0.30.0a4"
 description = "Interactive Rerun viewer for DimOS with click-to-navigate support"
 readme = "README.md"
 requires-python = ">=3.10"
-license = {text = "MIT OR Apache-2.0"}
-authors = [{name = "Dimensional Inc.", email = "engineering@dimensional.com"}]
+license = { text = "MIT OR Apache-2.0" }
+authors = [{ name = "Dimensional Inc.", email = "engineering@dimensional.com" }]
 classifiers = [
-    "Development Status :: 4 - Beta",
-    "Intended Audience :: Developers",
-    "Topic :: Scientific/Engineering",
-    "Topic :: Scientific/Engineering :: Visualization",
-    "Programming Language :: Rust",
-    "License :: OSI Approved :: MIT License",
-    "License :: OSI Approved :: Apache Software License",
-    "Operating System :: POSIX :: Linux",
-    "Operating System :: MacOS",
+  "Development Status :: 4 - Beta",
+  "Intended Audience :: Developers",
+  "Topic :: Scientific/Engineering",
+  "Topic :: Scientific/Engineering :: Visualization",
+  "Programming Language :: Rust",
+  "License :: OSI Approved :: MIT License",
+  "License :: OSI Approved :: Apache Software License",
+  "Operating System :: POSIX :: Linux",
+  "Operating System :: MacOS",
 ]
 
 [project.urls]

dimos/src/interaction/handle.rs

@@ -34,8 +34,8 @@ impl InteractionHandle {
             is_2d,
         };
 
-        if let Err(e) = self.tx.send(event) {
-            eprintln!("Failed to send click event: {}", e);
+        if let Err(err) = self.tx.send(event) {
+            eprintln!("Failed to send click event: {}", err);
         }
     }
 }

dimos/src/interaction/keyboard.rs

@@ -1,5 +1,5 @@
 //! Keyboard handler for WASD movement controls that publish Twist messages.
-//! 
+//!
 //! Converts keyboard input to robot velocity commands following teleop conventions:
 //! - WASD/arrows for linear/angular motion
 //! - QE for strafing
@@ -98,8 +98,8 @@ impl KeyboardHandler {
         // If not engaged, don't capture any keys
         if !self.engaged {
             if self.was_active {
-                if let Err(e) = self.publish_stop() {
-                    re_log::warn!("Failed to send stop on disengage: {e:?}");
+                if let Err(err) = self.publish_stop() {
+                    re_log::warn!("Failed to send stop on disengage: {err:?}");
                 }
                 self.was_active = false;
             }
@@ -112,8 +112,8 @@ impl KeyboardHandler {
         // Check for emergency stop (Space key pressed - one-shot action)
         if ctx.input(|i| i.key_pressed(egui::Key::Space)) {
             self.state.reset();
-            if let Err(e) = self.publish_stop() {
-                re_log::warn!("Failed to send emergency stop: {e:?}");
+            if let Err(err) = self.publish_stop() {
+                re_log::warn!("Failed to send emergency stop: {err:?}");
             }
             self.was_active = false;
             self.estop_flash = true;
@@ -122,13 +122,13 @@ impl KeyboardHandler {
 
         // Publish twist command if keys are active, or stop if just released
         if self.state.any_active() {
-            if let Err(e) = self.publish_twist() {
-                re_log::warn!("Failed to publish twist command: {e:?}");
+            if let Err(err) = self.publish_twist() {
+                re_log::warn!("Failed to publish twist command: {err:?}");
             }
             self.was_active = true;
         } else if self.was_active {
-            if let Err(e) = self.publish_stop() {
-                re_log::warn!("Failed to send stop on key release: {e:?}");
+            if let Err(err) = self.publish_stop() {
+                re_log::warn!("Failed to send stop on key release: {err:?}");
             }
             self.was_active = false;
         }
@@ -188,8 +188,8 @@ impl KeyboardHandler {
                     self.engaged = !self.engaged;
                     if !self.engaged {
                         // Send stop when disengaging
-                        if let Err(e) = self.publish_stop() {
-                            re_log::warn!("Failed to send stop on disengage: {e:?}");
+                        if let Err(err) = self.publish_stop() {
+                            re_log::warn!("Failed to send stop on disengage: {err:?}");
                         }
                         self.state.reset();
                         self.was_active = false;
@@ -204,8 +204,8 @@ impl KeyboardHandler {
             && ctx.input(|i| i.pointer.primary_clicked())
         {
             self.engaged = false;
-            if let Err(e) = self.publish_stop() {
-                re_log::warn!("Failed to send stop on outside click: {e:?}");
+            if let Err(err) = self.publish_stop() {
+                re_log::warn!("Failed to send stop on outside click: {err:?}");
             }
             self.state.reset();
             self.was_active = false;

dimos/src/interaction/lcm.rs

@@ -61,10 +61,13 @@ pub struct ClickEvent {
     pub x: f64,
     pub y: f64,
     pub z: f64,
+
     /// Rerun entity path (stored in frame_id per our convention).
     pub entity_path: String,
+
     /// Unix timestamp in seconds.
     pub timestamp_sec: i32,
+
     /// Nanosecond remainder.
     pub timestamp_nsec: i32,
 }

dimos/src/viewer.rs

@@ -12,10 +12,13 @@ static GLOBAL: re_memory::AccountingAllocator<mimalloc::MiMalloc> =
 
 /// LCM channel for click events (follows RViz convention)
 const LCM_CHANNEL: &str = "/clicked_point#geometry_msgs.PointStamped";
+
 /// Minimum time between click events (debouncing)
 const CLICK_DEBOUNCE_MS: u64 = 100;
+
 /// Maximum rapid clicks to log as warning
 const RAPID_CLICK_THRESHOLD: usize = 5;
+
 /// Default gRPC listen port (9877 to avoid conflict with stock Rerun on 9876)
 const DEFAULT_PORT: u16 = 9877;
 
@@ -231,7 +234,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
                                         );
                                     }
                                     Err(err) => {
-                                        re_log::error!("Failed to publish LCM click event: {err:?}");
+                                        re_log::error!("Failed to publish LCM click event: {err}");
                                     }
                                 }
                             }