fix(framework) broken carbonDesign links #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks great! it looks like the framework features links are also broken for carbon design https://github.com/marcolussetti/react-ui-roundup/tree/fix-carbon-links#framework-features would you mind taking a look at those too? |
|
Absolutely, I can take a look next week (pretty busy week this one!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a mandatory
components-prefix to carbonDesign links which is not implemented on all current links. This breaks a few of them. Additionally there's a case of two where the style marker at the end has been discontinued.Run
yarn generateas advised after, let me know if that should have been split to its own thing.