Skip to content

Commit 73ef2d7

Browse files
committed
libcontainer: devices: fix mips builds
It turns out that MIPS uses uint32 in the device number returned by stat(2), so explicitly wrap everything to make the compiler happy. I really wish that Go had C-like numeric type promotion. Signed-off-by: Aleksa Sarai <[email protected]>
1 parent a85a674 commit 73ef2d7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

libcontainer/devices/devices.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ func DeviceFromPath(path, permissions string) (*configs.Device, error) {
3030
}
3131

3232
var (
33-
devNumber = stat.Rdev
33+
devNumber = uint64(stat.Rdev)
3434
major = unix.Major(devNumber)
35+
minor = unix.Minor(devNumber)
3536
)
3637
if major == 0 {
3738
return nil, ErrNotADevice
@@ -51,7 +52,7 @@ func DeviceFromPath(path, permissions string) (*configs.Device, error) {
5152
Type: devType,
5253
Path: path,
5354
Major: int64(major),
54-
Minor: int64(unix.Minor(devNumber)),
55+
Minor: int64(minor),
5556
Permissions: permissions,
5657
FileMode: os.FileMode(mode),
5758
Uid: stat.Uid,

0 commit comments

Comments
 (0)