Skip to content

Commit 8f3e5f2

Browse files
committed
libcontainer/specconv/spec_linux: Add support for (no)lazytime
And also silent, loud, (no)iversion, and (no)acl. This is part of catching runC up with the spec, which punts valid options to mount(8) [1,2]. (no)acl is a filesystem-specific entry in mount(8), but it's represented by a MS_* flag in mount(2) so we need an entry in the translation table. [1]: https://github.com/opencontainers/runtime-spec/blame/v1.0.0-rc5/config.md#L68 [2]: opencontainers/runtime-spec#771 Signed-off-by: W. Trevor King <[email protected]>
1 parent f9a3fe8 commit 8f3e5f2

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

libcontainer/specconv/spec_linux.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -639,6 +639,7 @@ func parseMountOptions(options []string) (int, []int, string, int) {
639639
clear bool
640640
flag int
641641
}{
642+
"acl": {false, unix.MS_POSIXACL},
642643
"async": {true, unix.MS_SYNCHRONOUS},
643644
"atime": {true, unix.MS_NOATIME},
644645
"bind": {false, unix.MS_BIND},
@@ -647,11 +648,17 @@ func parseMountOptions(options []string) (int, []int, string, int) {
647648
"diratime": {true, unix.MS_NODIRATIME},
648649
"dirsync": {false, unix.MS_DIRSYNC},
649650
"exec": {true, unix.MS_NOEXEC},
651+
"iversion": {false, unix.MS_I_VERSION},
652+
"lazytime": {false, unix.MS_LAZYTIME},
653+
"loud": {true, unix.MS_SILENT},
650654
"mand": {false, unix.MS_MANDLOCK},
655+
"noacl": {true, unix.MS_POSIXACL},
651656
"noatime": {false, unix.MS_NOATIME},
652657
"nodev": {false, unix.MS_NODEV},
653658
"nodiratime": {false, unix.MS_NODIRATIME},
654659
"noexec": {false, unix.MS_NOEXEC},
660+
"noiversion": {true, unix.MS_I_VERSION},
661+
"nolazytime": {true, unix.MS_LAZYTIME},
655662
"nomand": {true, unix.MS_MANDLOCK},
656663
"norelatime": {true, unix.MS_RELATIME},
657664
"nostrictatime": {true, unix.MS_STRICTATIME},
@@ -661,6 +668,7 @@ func parseMountOptions(options []string) (int, []int, string, int) {
661668
"remount": {false, unix.MS_REMOUNT},
662669
"ro": {false, unix.MS_RDONLY},
663670
"rw": {true, unix.MS_RDONLY},
671+
"silent": {false, unix.MS_SILENT},
664672
"strictatime": {false, unix.MS_STRICTATIME},
665673
"suid": {true, unix.MS_NOSUID},
666674
"sync": {false, unix.MS_SYNCHRONOUS},

0 commit comments

Comments
 (0)