[fix][core] Check subquery in update set clause

Author: wt0530

core/src/main/java/org/apache/calcite/runtime/CalciteResource.java

@@ -1028,6 +1028,9 @@ ExInstWithCause<CalciteException> failedToAccessField(
   @BaseMessage("A table function at most has one input table with row semantics. Table function ''{0}'' has multiple input tables with row semantics")
   ExInst<SqlValidatorException> multipleRowSemanticsTables(String funcName);
 
+  @BaseMessage("update not support subquery node ''{0}'' ")
+  ExInst<SqlValidatorException> updateNotSupport(String nodeinfo);
+
   @BaseMessage("MATCH_CONDITION only allowed with ASOF JOIN")
   ExInst<CalciteException> matchConditionRequiresAsof();
 

core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java

@@ -62,6 +62,7 @@
 import org.apache.calcite.rel.type.RelDataTypeFactory;
 import org.apache.calcite.rel.type.RelDataTypeField;
 import org.apache.calcite.rex.*;
+import org.apache.calcite.runtime.CalciteContextException;
 import org.apache.calcite.schema.ColumnStrategy;
 import org.apache.calcite.schema.ModifiableTable;
 import org.apache.calcite.schema.ModifiableView;
@@ -115,6 +116,7 @@
 
 import static java.util.Objects.requireNonNull;
 import static org.apache.calcite.sql.validate.SqlValidatorImpl.isImplicitKey;
+import static org.apache.calcite.util.Static.RESOURCE;
 
 /**
  * Converts a SQL parse tree (consisting of
@@ -4204,7 +4206,21 @@ private RelNode convertDelete(SqlDelete call) {
         LogicalTableModify.Operation.DELETE, null, null, false);
   }
 
+  protected void checkSubqueryInSetClause(SqlUpdate call) {
+    if (call.getSourceExpressionList() != null) {
+      for (SqlNode node : call.getSourceExpressionList()) {
+        if (node instanceof SqlSelect) { // Don't allow sub-query in update set clause.
+          final CalciteContextException ex =
+                  validator.newValidationError(node, RESOURCE.updateNotSupport(node.toString()));
+          throw new RuntimeException(ex.getMessage(), ex);
+        }
+      }
+    }
+  }
+
   private RelNode convertUpdate(SqlUpdate call) {
+    checkSubqueryInSetClause(call);
+
     // Source table info
     // Map column to table it belongs to
     final Map<String, Integer> aliasTableMap = new HashMap<>();

core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties

@@ -335,6 +335,7 @@ InvalidOrderBy=Only tables with set semantics may be ordered. Invalid ORDER BY c
 MultipleRowSemanticsTables=A table function at most has one input table with row semantics. Table function ''{0}'' has multiple input tables with row semantics
 NoOperator=No operator for ''{0}'' with kind: ''{1}'', syntax: ''{2}'' during JSON deserialization
 MatchConditionRequiresAsof=MATCH_CONDITION only allowed with ASOF JOIN
+updateNotSupport=update not support subquery node ''{0}''
 AsofRequiresMatchCondition=ASOF JOIN missing MATCH_CONDITION
 AsofMatchMustBeComparison=ASOF JOIN MATCH_CONDITION must be a comparison between columns from the two inputs
 AsofConditionMustBeComparison=ASOF JOIN condition must be a conjunction of equality comparisons