Skip to content

Commit d2d318e

Browse files
nokiaMSgithubgxll
authored andcommitted
[fix][coding] Fix issue about float and double mod functions.
1 parent 06adad8 commit d2d318e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

coding/src/main/java/io/dingodb/expr/coding/ExprCoder.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package io.dingodb.expr.coding;
1818

1919
import io.dingodb.expr.common.type.DecimalType;
20+
import io.dingodb.expr.common.type.DoubleType;
21+
import io.dingodb.expr.common.type.FloatType;
2022
import io.dingodb.expr.common.type.Type;
2123
import io.dingodb.expr.common.type.Types;
2224
import io.dingodb.expr.runtime.expr.BinaryOpExpr;
@@ -283,7 +285,7 @@ public CodingFlag visitBinaryOpExpr(@NonNull BinaryOpExpr expr, OutputStream obj
283285
break;
284286
case ModFunFactory.NAME:
285287
t = (Type) expr.getOp().getKey();
286-
if (t instanceof DecimalType) {
288+
if (t instanceof DecimalType || t instanceof DoubleType || t instanceof FloatType) {
287289
//decimal type does not support pushing down.
288290
success = false;
289291
break;

0 commit comments

Comments
 (0)