Skip to content

Commit c43759a

Browse files
committed
[refact][vfs] Refact some log
1 parent 7d17e73 commit c43759a

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

src/client/vfs/data/reader/chunk_reader.cc

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
#include "client/vfs/data/reader/chunk_reader.h"
1818

19+
#include <fmt/format.h>
1920
#include <glog/logging.h>
2021

2122
#include <atomic>
@@ -155,7 +156,8 @@ void ChunkReader::DoRead(ContextSPtr ctx, const ChunkReadReq& req,
155156
"ChunkReader::DoRead.ConvertSliceReadReqToBlockReadReqs", *span);
156157

157158
for (auto& slice_req : slice_reqs) {
158-
VLOG(6) << "{} Read slice_req: " << slice_req.ToString();
159+
VLOG(6) << fmt::format("{} Read slice_req:", UUID(),
160+
slice_req.ToString());
159161

160162
if (slice_req.slice.has_value() && !slice_req.slice.value().is_zero) {
161163
std::vector<BlockReadReq> reqs = ConvertSliceReadReqToBlockReadReqs(
@@ -256,12 +258,28 @@ void ChunkReader::Invalidate() {
256258
slices_.clear();
257259
}
258260

261+
static std::string SlicesToString(const std::vector<Slice>& slices) {
262+
std::ostringstream oss;
263+
oss << "[";
264+
for (size_t i = 0; i < slices.size(); ++i) {
265+
oss << Slice2Str(slices[i]);
266+
if (i < slices.size() - 1) {
267+
oss << ", ";
268+
}
269+
}
270+
oss << "]";
271+
return oss.str();
272+
}
273+
259274
Status ChunkReader::GetSlices(ContextSPtr ctx, ChunkSlices* chunk_slices) {
260275
auto* tracer = hub_->GetTracer();
261276
auto span = tracer->StartSpanWithContext(kVFSDataMoudule, METHOD_NAME(), ctx);
262277

263278
std::lock_guard<std::mutex> lg(mutex_);
264279
if (cversion_ == kInvalidVersion) {
280+
VLOG(3) << fmt::format("{} cached chunk_slices invalidate, read from meta",
281+
UUID());
282+
265283
auto slice_span = tracer->StartSpanWithParent(
266284
kVFSDataMoudule, "ChunkReader::GetSlices.ReadSlice", *span);
267285

@@ -278,6 +296,10 @@ Status ChunkReader::GetSlices(ContextSPtr ctx, ChunkSlices* chunk_slices) {
278296
chunk_slices->version = cversion_;
279297
chunk_slices->slices = slices_;
280298

299+
VLOG(9) << fmt::format("{} GetSlices, version: {}, slices: {}", UUID(),
300+
chunk_slices->version,
301+
SlicesToString(chunk_slices->slices));
302+
281303
return Status::OK();
282304
}
283305

0 commit comments

Comments
 (0)