fix: memory leak when open a app on the browser too long

Author: dinhanhthi

docs/changelog.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## v0.1.2
+
+- Fix memory leak: `sync_log` table growing unbounded — add periodic pruning of entries older than 30 days
+- Fix memory leak: WebSocket client `connect()` not clearing pending reconnect timer, causing duplicate connections
+- Fix memory leak: `SyncEngine.stop()` not removing event listeners, clearing `wsClients`, or clearing `ignoreMatcherCache`
+- Fix memory leak: debounce timers not cleaned up when individual repo/service watchers are stopped
+
 ## v0.1.1
 
 - Fix excessive git commits in data repo on every server startup (only `lastSeen` timestamp change in `machines.json`)

landing/index.html

@@ -112,7 +112,7 @@
           AI Sync
           <span
             class="rounded-full bg-muted px-1.5 py-0.5 text-xs h-fit font-medium text-muted-foreground"
-            >v0.1.1</span
+            >v0.1.2</span
           >
         </a>
         <div class="flex items-center gap-3">

package.json

@@ -1,7 +1,7 @@
 {
   "name": "ai-sync",
   "author": "Anh-Thi Dinh",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "repository": "https://github.com/anhthiding/ai-sync",
   "private": true,
   "license": "MIT",

packages/server/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ai-sync/server",
   "author": "Anh-Thi Dinh",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "repository": "https://github.com/anhthiding/ai-sync",
   "private": true,
   "license": "MIT",

packages/server/src/services/file-watcher.ts

@@ -56,6 +56,15 @@ export class FileWatcherService extends EventEmitter {
     return true;
   }
 
+  private clearDebounceTimersForPrefix(prefix: string): void {
+    for (const [key, timer] of this.debounceTimers) {
+      if (key.startsWith(prefix)) {
+        clearTimeout(timer);
+        this.debounceTimers.delete(key);
+      }
+    }
+  }
+
   private debounce(key: string, fn: () => void): void {
     const existing = this.debounceTimers.get(key);
     if (existing) clearTimeout(existing);
@@ -125,6 +134,7 @@ export class FileWatcherService extends EventEmitter {
     if (watcher) {
       await watcher.close();
       this.targetWatchers.delete(repoId);
+      this.clearDebounceTimersForPrefix(`target:${repoId}:`);
     }
   }
 
@@ -185,6 +195,7 @@ export class FileWatcherService extends EventEmitter {
     if (watcher) {
       await watcher.close();
       this.serviceTargetWatchers.delete(serviceId);
+      this.clearDebounceTimersForPrefix(`serviceTarget:${serviceId}:`);
     }
   }
 

packages/server/src/services/sync-engine.ts

@@ -87,6 +87,7 @@ export class SyncEngine {
   private pollingTimer: NodeJS.Timeout | null = null;
   private wsClients: Set<{ send: (data: string) => void }> = new Set();
   private ignoreMatcherCache = new Map<string, picomatch.Matcher>();
+  private lastLogCleanup = 0;
 
   constructor(db: Database.Database) {
     this.db = db;
@@ -191,6 +192,7 @@ export class SyncEngine {
         await this.scanAllServicesForNewFiles();
         await this.syncAllRepos();
         await this.syncAllServices();
+        this.pruneOldSyncLogs();
       } catch (err) {
         console.error('Polling error:', err);
       }
@@ -200,12 +202,27 @@ export class SyncEngine {
     }, interval);
   }
 
+  private pruneOldSyncLogs(): void {
+    const now = Date.now();
+    // Run cleanup at most once per hour
+    if (now - this.lastLogCleanup < 3_600_000) return;
+    this.lastLogCleanup = now;
+    try {
+      this.db.prepare("DELETE FROM sync_log WHERE created_at < datetime('now', '-30 days')").run();
+    } catch (err) {
+      console.error('Failed to prune sync_log:', err);
+    }
+  }
+
   async stop(): Promise<void> {
     if (this.pollingTimer) {
       clearTimeout(this.pollingTimer);
       this.pollingTimer = null;
     }
+    this.watcher.removeAllListeners();
     await this.watcher.stopAll();
+    this.wsClients.clear();
+    this.ignoreMatcherCache.clear();
     console.log('Sync engine stopped');
   }
 

packages/ui/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@ai-sync/ui",
   "author": "Anh-Thi Dinh",
-  "version": "0.1.1",
+  "version": "0.1.2",
   "repository": "https://github.com/anhthiding/ai-sync",
   "private": true,
   "license": "MIT",

packages/ui/src/lib/ws.ts

@@ -6,6 +6,16 @@ class WebSocketClient {
   private reconnectTimer: ReturnType<typeof setTimeout> | null = null;
 
   connect(): void {
+    if (this.reconnectTimer) {
+      clearTimeout(this.reconnectTimer);
+      this.reconnectTimer = null;
+    }
+    if (this.ws) {
+      this.ws.onclose = null;
+      this.ws.onerror = null;
+      this.ws.onmessage = null;
+      this.ws.close();
+    }
     const protocol = window.location.protocol === 'https:' ? 'wss:' : 'ws:';
     const wsUrl = `${protocol}//${window.location.host}/ws`;
     this.ws = new WebSocket(wsUrl);