Skip to content

Commit 1cb289f

Browse files
authored
Allow unspecified footprints in 3d model export (#336)
1 parent 4d3f763 commit 1cb289f

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

crates/pcb/src/release.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1461,7 +1461,8 @@ fn generate_step_model(info: &ReleaseInfo, _spinner: &Spinner) -> Result<()> {
14611461
.arg("--output")
14621462
.arg(step_path.to_string_lossy())
14631463
.arg("--no-dnp")
1464-
.arg("--no-unspecified")
1464+
// FIXME: kicad-imported projects have unspecified footprints, so allow these temporarily
1465+
// .arg("--no-unspecified")
14651466
.arg("--include-silkscreen")
14661467
.arg(kicad_pcb_path.to_string_lossy())
14671468
.log_file(devnull)
@@ -1500,7 +1501,8 @@ fn generate_vrml_model(info: &ReleaseInfo, _spinner: &Spinner) -> Result<()> {
15001501
.arg("--units")
15011502
.arg("mm")
15021503
.arg("--no-dnp")
1503-
.arg("--no-unspecified")
1504+
// FIXME: kicad-imported projects have unspecified footprints, so allow these temporarily
1505+
// .arg("--no-unspecified")
15041506
.arg(kicad_pcb_path.to_string_lossy())
15051507
.log_file(devnull)
15061508
.suppress_error_output(true)
@@ -1538,7 +1540,8 @@ fn generate_glb_model(info: &ReleaseInfo, _spinner: &Spinner) -> Result<()> {
15381540
.arg("--subst-models")
15391541
.arg("--force")
15401542
.arg("--no-dnp")
1541-
.arg("--no-unspecified")
1543+
// FIXME: kicad-imported projects have unspecified footprints, so allow these temporarily
1544+
// .arg("--no-unspecified")
15421545
.arg("--include-pads")
15431546
.arg("--include-silkscreen")
15441547
.arg(kicad_pcb_path.to_string_lossy())

0 commit comments

Comments
 (0)