Warn if manufacturer is specified, but MPN is not (#289)

Author: akhilles

crates/pcb-sch/src/physical.rs

@@ -3623,7 +3623,6 @@ mod tests {
 
         let heap = Heap::new();
         let range = heap.alloc(physical_range(3.0, 3.6, PhysicalUnit::Volts));
-        let gnd_str = heap.alloc("0V");
 
         // Get the range from heap
         let range_val = range.downcast_ref::<PhysicalRange>().unwrap();

crates/pcb-zen-core/src/lang/component.rs

@@ -1066,6 +1066,35 @@ where
                         .map(|s| s.to_owned())
                 });
 
+            // Warn if manufacturer is set but mpn is missing
+            if final_manufacturer.is_some() && final_mpn.is_none() {
+                if let Some(call_site) = eval_ctx.call_stack_top_location() {
+                    use crate::lang::error::CategorizedDiagnostic;
+                    use crate::Diagnostic;
+                    use starlark::errors::EvalSeverity;
+
+                    let body = "MPN must be specified if manufacturer is specified";
+                    let kind = "bom.incomplete_manufacturer";
+
+                    let source_error =
+                        CategorizedDiagnostic::new(body.to_string(), kind.to_string())
+                            .ok()
+                            .map(|c| std::sync::Arc::new(anyhow::Error::new(c)));
+
+                    let diag = Diagnostic {
+                        path: call_site.filename().to_string(),
+                        span: Some(call_site.resolve_span()),
+                        severity: EvalSeverity::Warning,
+                        body: body.to_string(),
+                        call_stack: None,
+                        child: None,
+                        source_error,
+                        suppressed: false,
+                    };
+                    eval_ctx.add_diagnostic(diag);
+                }
+            }
+
             // If datasheet is not explicitly provided, try to get it from properties, then symbol properties
             // Skip empty strings and "~" (KiCad's placeholder for no datasheet) - prefer None over empty
             let final_datasheet = datasheet_val

crates/pcb-zen-core/tests/snapshots/component__component_manufacturer_from_symbol.snap

@@ -2,6 +2,7 @@
 source: crates/pcb-zen-core/tests/component.rs
 expression: output
 ---
+Warning: test.zen:2:1-10:2 MPN must be specified if manufacturer is specified
 {
     <root>: Module {
         path: <root>,

crates/pcb-zen-core/tests/snapshots/component__component_with_manufacturer.snap

@@ -2,6 +2,7 @@
 source: crates/pcb-zen-core/tests/component.rs
 expression: output
 ---
+Warning: test.zen:2:1-14:2 MPN must be specified if manufacturer is specified
 {
     <root>: Module {
         path: <root>,