Add pcb import tests (#523)

* Add `pcb import` tests

* Don't block ERC/DRC issues on `pcb import`

* Build before layout

Author: akhilles

.github/workflows/e2e.yml

@@ -100,3 +100,25 @@ jobs:
 
       - name: Test stdlib builds
         run: pcb build stdlib
+
+      - name: Checkout kicad-test-fixtures
+        uses: actions/checkout@v5
+        with:
+          repository: diodeinc/kicad-test-fixtures
+          token: ${{ secrets.DIODE_ROBOT_TOKEN }}
+          path: kicad-test-fixtures
+
+      - name: Test pcb import (E2E)
+        run: |
+          pcb new --workspace test-import --repo github.com/test/test-import
+          find kicad-test-fixtures -name '*.kicad_pro' | while IFS= read -r pro; do
+            echo "=== Importing $pro ==="
+            pcb import "$pro" ./test-import
+          done
+          for board_dir in ./test-import/boards/*/; do
+            board=$(basename "$board_dir")
+            echo "=== Build $board ==="
+            pcb build "./test-import/boards/$board/$board.zen"
+            echo "=== Layout $board ==="
+            pcb layout "./test-import/boards/$board/$board.zen" --no-open
+          done

crates/pcb/src/import/flow.rs

@@ -5,7 +5,11 @@ pub(super) fn execute(args: ImportArgs) -> Result<()> {
     let ctx = ImportContext::new(args)?;
 
     let discovered = Discovered::run(ctx)?;
-    prepare_output(&discovered.ctx.paths, &discovered.selection)?;
+    prepare_output(
+        &discovered.ctx.paths,
+        &discovered.selection,
+        &discovered.ctx.args,
+    )?;
     let validated = Validated::run(discovered)?;
     let extracted = Extracted::run(validated)?;
     let hierarchized = Hierarchized::run(extracted);
@@ -60,18 +64,29 @@ impl Discovered {
     }
 }
 
-fn prepare_output(paths: &ImportPaths, selection: &ImportSelection) -> Result<()> {
+fn prepare_output(
+    paths: &ImportPaths,
+    selection: &ImportSelection,
+    args: &ImportArgs,
+) -> Result<()> {
     let board_dir = paths
         .workspace_root
         .join("boards")
         .join(&selection.board_name);
     if board_dir.exists() {
-        std::fs::remove_dir_all(&board_dir).with_context(|| {
-            format!(
-                "Failed to remove existing board dir {}",
+        if args.force {
+            std::fs::remove_dir_all(&board_dir).with_context(|| {
+                format!(
+                    "Failed to remove existing board dir {}",
+                    board_dir.display()
+                )
+            })?;
+        } else {
+            anyhow::bail!(
+                "Board directory already exists: {}. Use --force to overwrite.",
                 board_dir.display()
-            )
-        })?;
+            );
+        }
     }
 
     let board_scaffold = crate::new::scaffold_board(&paths.workspace_root, &selection.board_name)?;

crates/pcb/src/import/types.rs

@@ -104,7 +104,7 @@ pub struct ImportArgs {
     #[arg(value_name = "OUTPUT_DIR", value_hint = clap::ValueHint::AnyPath)]
     pub output_dir: PathBuf,
 
-    /// Skip interactive confirmations (continue even if ERC/DRC errors are present)
+    /// Overwrite existing board directory if it already exists
     #[arg(long = "force")]
     pub force: bool,
 }

crates/pcb/src/import/validate.rs

@@ -9,7 +9,7 @@ use pcb_zen_core::Diagnostics;
 pub(super) fn validate(
     paths: &ImportPaths,
     selection: &ImportSelection,
-    args: &ImportArgs,
+    _args: &ImportArgs,
 ) -> Result<ImportValidationRun> {
     let kicad_pro_abs = paths.kicad_project_root.join(&selection.selected.kicad_pro);
     let kicad_sch_abs = paths.kicad_project_root.join(&selection.selected.kicad_sch);
@@ -87,26 +87,9 @@ pub(super) fn validate(
 
     let error_count = diagnostics_for_render.error_count();
     if error_count > 0 {
-        if args.force {
-            eprintln!(
-                "Warning: KiCad ERC/DRC reported {error_count} errors; continuing due to --force."
-            );
-        } else if !crate::tty::is_interactive() || std::env::var("CI").is_ok() {
-            anyhow::bail!(
-                "KiCad ERC/DRC reported {error_count} errors. Fix them, or re-run in an interactive terminal to confirm continuing."
-            );
-        } else {
-            let continue_anyway = inquire::Confirm::new(&format!(
-                "KiCad ERC/DRC reported {error_count} errors. Continue anyway?"
-            ))
-            .with_default(false)
-            .prompt()
-            .context("Failed to read confirmation")?;
-
-            if !continue_anyway {
-                anyhow::bail!("Aborted due to KiCad ERC/DRC errors");
-            }
-        }
+        eprintln!(
+            "Warning: KiCad ERC/DRC reported {error_count} errors; these do not block import."
+        );
     }
 
     Ok(ImportValidationRun {