Address PR comments

Author: akhilles

crates/pcb/src/mcp.rs

@@ -97,6 +97,10 @@ fn execute_eval(args: EvalArgs) -> Result<()> {
 fn should_render_inline_images(args: &EvalArgs, result: &pcb_mcp::ExecutionResult) -> bool {
     args.output_dir.is_none()
         && !result.images.is_empty()
+        && result
+            .images
+            .iter()
+            .all(|image| image.mime_type == "image/png")
         && crate::tty::is_interactive()
         && matches!(detect_inline_image_protocol(), InlineImageProtocol::Kitty)
 }
@@ -122,21 +126,15 @@ fn detect_inline_image_protocol() -> InlineImageProtocol {
     InlineImageProtocol::None
 }
 
-fn render_inline_images_to_terminal(images: &[pcb_mcp::ImageData]) -> Result<usize> {
-    let mut rendered = 0usize;
+fn render_inline_images_to_terminal(images: &[pcb_mcp::ImageData]) -> Result<()> {
     for image in images {
-        if image.mime_type != "image/png" {
-            continue;
-        }
-
         use base64::Engine;
         let bytes = base64::engine::general_purpose::STANDARD
             .decode(&image.data)
             .context("Failed to decode image for inline terminal rendering")?;
         render_kitty_png(&bytes)?;
-        rendered += 1;
     }
-    Ok(rendered)
+    Ok(())
 }
 
 fn render_kitty_png(png_bytes: &[u8]) -> Result<()> {
@@ -145,15 +143,21 @@ fn render_kitty_png(png_bytes: &[u8]) -> Result<()> {
     let encoded = base64::engine::general_purpose::STANDARD.encode(png_bytes);
     let mut stdout = std::io::stdout().lock();
     let mut i = 0usize;
+    let mut first_chunk = true;
     while i < encoded.len() {
         let end = std::cmp::min(i + 4096, encoded.len());
         let more = if end < encoded.len() { 1 } else { 0 };
-        write!(
-            stdout,
-            "\x1b_Gf=100,a=T,m={};{}\x1b\\",
-            more,
-            &encoded[i..end]
-        )?;
+        if first_chunk {
+            write!(
+                stdout,
+                "\x1b_Gf=100,a=T,m={};{}\x1b\\",
+                more,
+                &encoded[i..end]
+            )?;
+            first_chunk = false;
+        } else {
+            write!(stdout, "\x1b_Gm={};{}\x1b\\", more, &encoded[i..end])?;
+        }
         i = end;
     }
     writeln!(stdout)?;
@@ -182,8 +186,8 @@ fn resolve_eval_output_dir(output_dir: Option<&Path>) -> Result<PathBuf> {
         return Ok(std::env::current_dir()?.join(path));
     }
 
-    Ok(std::env::current_dir()?
-        .join("mcp-eval-artifacts")
+    Ok(std::env::temp_dir()
+        .join("pcb-mcp-eval-artifacts")
         .join("inline"))
 }