Fix rubocop errors

Author: diogot

lib/danger_plugin.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/plugin'

lib/danger_xcode_summary.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'xcode_summary/gem_version'

lib/xcode_summary/gem_version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module XcodeSummary
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.5.0'
 end

lib/xcode_summary/plugin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Danger
@@ -196,9 +198,9 @@ def errors(xcode_summary)
       errors.delete_if(&ignored_results)
     end
 
-    def parse_location(h)
-      file_path, line, _column = h[:file_path].split(':')
-      Location.new(h[:file_name], file_path, line.to_i)
+    def parse_location(input)
+      file_path, line, _column = input[:file_path].split(':')
+      Location.new(input[:file_name], file_path, line.to_i)
     end
 
     def parse_test_location(failure)
@@ -225,13 +227,12 @@ def format_path(path)
     def parse_filename(path)
       regex = /^(.*?):(\d*):?\d*$/
       match = path.match(regex)
-      if match
-        match.captures
-      end
+      match&.captures
     end
 
     def relative_path(path)
       return nil if project_root.nil?
+
       path.gsub(project_root, '')
     end
 
@@ -245,38 +246,38 @@ def escape_reason(reason)
       reason.gsub('>', '\>').gsub('<', '\<')
     end
 
-    def format_compile_warning(h)
-      path = relative_path(h[:file_path])
+    def format_compile_warning(input)
+      path = relative_path(input[:file_path])
       return nil if should_ignore_warning?(path)
 
       path_link = format_path(path)
 
-      warning = "**#{path_link}**: #{escape_reason(h[:reason])}  <br />"
-      if h[:line] && !h[:line].empty?
+      warning = "**#{path_link}**: #{escape_reason(input[:reason])}  <br />"
+      if input[:line] && !input[:line].empty?
         "#{warning}" \
           "```\n" \
-          "#{h[:line]}\n" \
+          "#{input[:line]}\n" \
           '```'
       else
         warning
       end
     end
 
-    def format_format_file_missing_error(h)
-      path = relative_path(h[:file_path])
+    def format_format_file_missing_error(input)
+      path = relative_path(input[:file_path])
       path_link = format_path(path)
-      "**#{escape_reason(h[:reason])}**: #{path_link}"
+      "**#{escape_reason(input[:reason])}**: #{path_link}"
     end
 
-    def format_undefined_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> Symbol: #{h[:symbol]}  <br />" \
-        "> Referenced from: #{h[:reference]}"
+    def format_undefined_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> Symbol: #{input[:symbol]}  <br />" \
+        "> Referenced from: #{input[:reference]}"
     end
 
-    def format_duplicate_symbols(h)
-      "#{h[:message]}  <br />" \
-        "> #{h[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
+    def format_duplicate_symbols(input)
+      "#{input[:message]}  <br />" \
+        "> #{input[:file_paths].map { |path| path.split('/').last }.join('<br /> ')}"
     end
 
     def format_test_failure(suite_name, failure)

spec/spec_helper.rb

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'pathname'
-ROOT = Pathname.new(File.expand_path('../../', __FILE__))
+ROOT = Pathname.new(File.expand_path('..', __dir__))
 $LOAD_PATH.unshift((ROOT + 'lib').to_s)
 $LOAD_PATH.unshift((ROOT + 'spec').to_s)
 

spec/xcode_summary_spec.rb

@@ -1,4 +1,6 @@
-require File.expand_path('../spec_helper', __FILE__)
+# frozen_string_literal: true
+
+require File.expand_path('spec_helper', __dir__)
 
 module Danger
   describe Danger::DangerXcodeSummary do
@@ -73,7 +75,7 @@ module Danger
           @xcode_summary.report('spec/fixtures/summary.json')
           expect(@dangerfile.status_report[:warnings]).to eq [
             # rubocop:disable LineLength
-            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```",
+            "**<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/Bla.m#L32'>MyWeight/Bla.m#L32</a>**: Value stored to 'theme' is never read  <br />```\n            theme = *ptr++;\n```"
             # rubocop:enable LineLength
           ]
         end
@@ -89,7 +91,7 @@ module Danger
           expect(@dangerfile.status_report[:errors]).to eq [
             # rubocop:disable LineLength
             '**MyWeight.MyWeightSpec**: works_with_success, expected to eventually not be nil, got \<nil\>  <br />  ' \
-            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>",
+            "<a href='https://github.com/diogot/danger-xcode_summary/blob/129jef029jf029fj2039fj203f92/MyWeight/MyWeightTests/Tests.swift#L86'>MyWeight/MyWeightTests/Tests.swift#L86</a>"
             # rubocop:enable LineLength
           ]
         end
@@ -205,9 +207,7 @@ module Danger
       describe 'where request source' do
         it 'should be bitbucket' do
           path = @xcode_summary.send(:format_path, 'lib/xcode_summary/plugin.rb:3')
-          # rubocop:disable LineLength
-          expect(path).to eq "lib/xcode_summary/plugin.rb:3"
-          # rubocop:enable LineLength
+          expect(path).to eq 'lib/xcode_summary/plugin.rb:3'
         end
       end
     end