Merge pull request #31 from YogaGlo/master

(feature): Add ignores_warnings property

Author: diogot

.rubocop.yml

@@ -12,7 +12,7 @@ Lint/UselessAssignment:
     - '**/spec/**/*'
 
 # HoundCI doesn't like this rule
-Style/DotPosition:
+Layout/DotPosition:
   Enabled: false
 
 # Cop supports --auto-correct.

README.md

@@ -110,6 +110,12 @@ xcode_summary.ignored_results { |result|
 xcode_summary.report 'xcodebuild.json'
 ```
 
+You can use `ignores_warnings` to supress warnings and shows only errors.
+
+```ruby
+xcode_summary.ignores_warnings = true
+```
+
 You can use `inline_mode`.
 When this value is enabled, each warnings and errors are commented on each lines.
 

lib/xcode_summary/plugin.rb

@@ -60,6 +60,12 @@ class DangerXcodeSummary < Plugin
     # @return   [Boolean]
     attr_accessor :inline_mode
 
+    # Defines if warnings should be included or not
+    # Defaults to `false`.
+    # @param    [Boolean] value
+    # @return   [Boolean]
+    attr_accessor :ignores_warnings
+
     # rubocop:disable Lint/DuplicateMethods
     def project_root
       root = @project_root || Dir.pwd
@@ -86,6 +92,10 @@ def test_summary
     def inline_mode
       @inline_mode || false
     end
+
+    def ignores_warnings
+      @ignores_warnings || false
+    end
     # rubocop:enable Lint/DuplicateMethods
 
     # Reads a file with JSON Xcode summary and reports it.
@@ -148,6 +158,10 @@ def messages(xcode_summary)
     end
 
     def warnings(xcode_summary)
+      if ignores_warnings
+        return []
+      end
+
       warnings = [
         xcode_summary.fetch(:warnings, []).map { |message| Result.new(message, nil) },
         xcode_summary.fetch(:ld_warnings, []).map { |message| Result.new(message, nil) },

spec/fixtures/warnings_errors.json

@@ -0,0 +1,32 @@
+{
+  "warnings": [
+    "some warning",
+    "another warning"
+  ],
+  "ld_warnings": [
+
+  ],
+  "compile_warnings": [
+
+  ],
+  "errors": [
+    "some error",
+    "another error"
+  ],
+  "compile_errors": [
+
+  ],
+  "file_missing_errors": [
+
+  ],
+  "undefined_symbols_errors": [
+
+  ],
+  "duplicate_symbols_errors": [
+
+  ],
+  "tests_failures": {
+  },
+  "tests_summary_messages": [
+  ]
+}

spec/xcode_summary_spec.rb

@@ -156,7 +156,7 @@ module Danger
             expect(@dangerfile.status_report[:warnings]).to eq ['another warning']
           end
 
-          it 'report waring and error counts with no errors' do
+          it 'report warning and error counts with no errors' do
             result = @xcode_summary.warning_error_count('spec/fixtures/errors.json')
             expect(result).to eq '{"warnings":0,"errors":1}'
           end
@@ -166,6 +166,28 @@ module Danger
             expect(result).to eq '{"warnings":1,"errors":0}'
           end
         end
+
+        context 'with ignores_warnings' do
+          before do
+            @xcode_summary.ignores_warnings = true
+          end
+
+          it 'asserts no ld warnings' do
+            @xcode_summary.report('spec/fixtures/ld_warnings.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+          end
+
+          it 'asserts no errors' do
+            @xcode_summary.report('spec/fixtures/warnings_errors.json')
+            expect(@dangerfile.status_report[:warnings]).to eq []
+            expect(@dangerfile.status_report[:errors]).to eq ['some error', 'another error']
+          end
+
+          it 'report warning and error counts with no warning' do
+            result = @xcode_summary.warning_error_count('spec/fixtures/warnings_errors.json')
+            expect(result).to eq '{"warnings":0,"errors":2}'
+          end
+        end
       end
     end