Remove secrets from config __repr__ (#417)

Author: droserasprout

CHANGELOG.md

@@ -9,6 +9,7 @@
 ### Fixed
 
 * cli: Fixed `hasura configure` command crash when models have empty `Meta.table`.
+* config: Removed secrets from config `__repr__`.
 
 ## [5.2.2] - 2022-07-03
 

src/dipdup/config.py

@@ -126,7 +126,7 @@ class PostgresDatabaseConfig:
     database: str = DEFAULT_POSTGRES_DATABASE
     port: int = DEFAULT_POSTGRES_PORT
     schema_name: str = DEFAULT_POSTGRES_SCHEMA
-    password: str = ''
+    password: str = field(default='', repr=False)
     immune_tables: Tuple[str, ...] = field(default_factory=tuple)
     connection_timeout: int = 60
 
@@ -1023,7 +1023,7 @@ class HasuraConfig:
     """
 
     url: str
-    admin_secret: Optional[str] = None
+    admin_secret: Optional[str] = field(default=None, repr=False)
     create_source: bool = False
     source: str = 'default'
     select_limit: int = 100

tests/test_dipdup/test_config.py

@@ -7,6 +7,8 @@
 
 from dipdup.config import ContractConfig
 from dipdup.config import DipDupConfig
+from dipdup.config import HasuraConfig
+from dipdup.config import PostgresDatabaseConfig
 from dipdup.config import TzktDatasourceConfig
 from dipdup.datasources.subscription import OriginationSubscription
 from dipdup.datasources.subscription import TransactionSubscription
@@ -15,10 +17,10 @@
 
 
 class ConfigTest(IsolatedAsyncioTestCase):
-    async def asyncSetUp(self):
+    async def asyncSetUp(self) -> None:
         self.path = join(dirname(__file__), 'dipdup.yml')
 
-    async def test_load_initialize(self):
+    async def test_load_initialize(self) -> None:
         config = DipDupConfig.load([self.path])
 
         config.initialize()
@@ -59,15 +61,15 @@ async def test_subscriptions(self) -> None:
             config.indexes['hen_mainnet'].subscriptions,  # type: ignore
         )
 
-    async def test_validators(self):
+    async def test_validators(self) -> None:
         with self.assertRaises(ConfigurationError):
             ContractConfig(address='KT1lalala')
         with self.assertRaises(ConfigurationError):
             ContractConfig(address='lalalalalalalalalalalalalalalalalala')
         with self.assertRaises(ConfigurationError):
             TzktDatasourceConfig(kind='tzkt', url='not_an_url')
 
-    async def test_dump(self):
+    async def test_dump(self) -> None:
         config = DipDupConfig.load([self.path])
         config.initialize()
 
@@ -77,3 +79,18 @@ async def test_dump(self):
 
         config = DipDupConfig.load([tmp], environment=False)
         config.initialize()
+
+    async def test_secrets(self) -> None:
+        db_config = PostgresDatabaseConfig(
+            kind='postgres',
+            host='localhost',
+            password='SeCrEt=)',
+        )
+        hasura_config = HasuraConfig(
+            url='https://localhost',
+            admin_secret='SeCrEt=)',
+        )
+        self.assertIn('localhost', str(db_config))
+        self.assertNotIn('SeCrEt=)', str(db_config))
+        self.assertIn('localhost', str(db_config))
+        self.assertNotIn('SeCrEt=)', str(hasura_config))