Add warning on using multiple indexes with the same contract (#107)

Author: droserasprout

src/dipdup/config.py

@@ -605,23 +605,9 @@ class BigMapIndexConfig(IndexConfig):
     first_block: int = 0
     last_block: int = 0
 
-
-@dataclass
-class BlockHandlerConfig(HandlerConfig):
-    pattern = None
-
-
-@dataclass
-class BlockIndexConfig(IndexConfig):
-    """Stub, not implemented"""
-
-    kind: Literal['block']
-    datasource: Union[str, TzktDatasourceConfig]
-    handlers: List[BlockHandlerConfig]
-
-    stateless: bool = False
-    first_block: int = 0
-    last_block: int = 0
+    @property
+    def contracts(self) -> List[ContractConfig]:
+        return list(set([cast(ContractConfig, handler_config.contract) for handler_config in self.handlers]))
 
 
 @dataclass
@@ -631,8 +617,8 @@ class IndexTemplateConfig:
     values: Dict[str, str]
 
 
-IndexConfigT = Union[OperationIndexConfig, BigMapIndexConfig, BlockIndexConfig, IndexTemplateConfig]
-IndexConfigTemplateT = Union[OperationIndexConfig, BigMapIndexConfig, BlockIndexConfig]
+IndexConfigT = Union[OperationIndexConfig, BigMapIndexConfig, IndexTemplateConfig]
+IndexConfigTemplateT = Union[OperationIndexConfig, BigMapIndexConfig]
 HandlerPatternConfigT = Union[OperationHandlerOriginationPatternConfig, OperationHandlerTransactionPatternConfig]
 
 
@@ -714,14 +700,6 @@ class DipDupConfig:
     jobs: Optional[Dict[str, JobConfig]] = None
     sentry: Optional[SentryConfig] = None
 
-    @property
-    def environment(self) -> Dict[str, str]:
-        return self._environment
-
-    @property
-    def filenames(self) -> List[str]:
-        return self._filenames
-
     def __post_init_post_parse__(self):
         self._filenames: List[str] = []
         self._environment: Dict[str, str] = {}
@@ -730,6 +708,14 @@ def __post_init_post_parse__(self):
         self._initialized = []
         self.validate()
 
+    @property
+    def environment(self) -> Dict[str, str]:
+        return self._environment
+
+    @property
+    def filenames(self) -> List[str]:
+        return self._filenames
+
     def validate(self) -> None:
         if isinstance(self.database, SqliteDatabaseConfig) and self.hasura:
             raise ConfigurationError('SQLite DB engine is not supported by Hasura')

src/dipdup/dipdup.py

@@ -1,7 +1,10 @@
 import asyncio
 import hashlib
 import logging
+import operator
+from collections import Counter
 from contextlib import AsyncExitStack, asynccontextmanager, suppress
+from functools import reduce
 from os import listdir
 from os.path import join
 from typing import Dict, List, Optional, cast
@@ -18,6 +21,7 @@
     BcdDatasourceConfig,
     BigMapIndexConfig,
     CoinbaseDatasourceConfig,
+    ContractConfig,
     DatasourceConfigT,
     DipDupConfig,
     IndexConfigTemplateT,
@@ -84,9 +88,18 @@ async def reload_config(self) -> None:
 
         for index_config in self._ctx.config.indexes.values():
             if isinstance(index_config, IndexTemplateConfig):
-                raise RuntimeError
+                raise RuntimeError('Config is not initialized')
             await self.add_index(index_config)
 
+        contracts = [index._config.contracts for index in self._indexes.values() if index._config.contracts]
+        plain_contracts = reduce(operator.add, contracts)
+        duplicate_contracts = [cast(ContractConfig, item).name for item, count in Counter(plain_contracts).items() if count > 1]
+        if duplicate_contracts:
+            self._logger.warning(
+                "The following contracts are used in more than one index: %s. Make sure you know what you're doing.",
+                ' '.join(duplicate_contracts),
+            )
+
         self._ctx.reset()
 
     async def dispatch_operations(self, datasource: TzktDatasource, operations: List[OperationData], block: HeadBlockData) -> None:

src/dipdup/utils.py

@@ -6,11 +6,13 @@
 import pkgutil
 import time
 import types
+from collections import defaultdict
 from contextlib import asynccontextmanager
+from functools import reduce
 from logging import Logger
 from os import listdir, makedirs
 from os.path import dirname, exists, getsize, join
-from typing import Any, AsyncIterator, Dict, Iterator, List, Optional, TextIO, Tuple, Type
+from typing import Any, AsyncIterator, Callable, DefaultDict, Dict, Iterator, List, Optional, Sequence, TextIO, Tuple, Type, TypeVar
 
 import humps  # type: ignore
 from tortoise import Tortoise
@@ -147,6 +149,19 @@ def set_decimal_context(package: str) -> None:
         decimal.setcontext(context)
 
 
+_T = TypeVar('_T')
+_TT = TypeVar('_TT')
+
+
+def groupby(seq: Sequence[_T], key: Callable[[Any], _TT]) -> DefaultDict[_TT, List[_T]]:
+    """Group by key into defaultdict"""
+    return reduce(
+        lambda grp, val: grp[key(val)].append(val) or grp,  # type: ignore
+        seq,
+        defaultdict(list),
+    )
+
+
 class FormattedLogger(Logger):
     def __init__(
         self,