mypy --strict, rewrite tests, bugfixes (#543)

Author: droserasprout

CHANGELOG.md

@@ -4,17 +4,26 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog], and this project adheres to [Semantic Versioning].
 
-## [Unreleased]
+## [6.3.1] - 2022-11-25
 
 ### Fixed
 
-* codegen: Include PEP 561 marker in generated packages.
-* codegen: Untyped originations are now correctly handled.
-* codegen: Fixed `alias` config field having no effect on originations.
-* codegen: Fixed optional arguments in generated callbacks.
-* config: Suggest snake_case for package name.
-* index: Do not deserialize originations matched by the `source` filter.
-* index: Wrap storage deserialization exceptions with `InvalidDataError`.
+- cli: Do not apply cli hacks on module import.
+- codegen: Include PEP 561 marker in generated packages.
+- codegen: Untyped originations are now correctly handled.
+- codegen: Fixed `alias` config field having no effect on originations.
+- codegen: Fixed optional arguments in generated callbacks.
+- config: Suggest snake_case for package name.
+- config: Fixed crash with `RuntimeError` when index has no subscriptions.
+- http: Limit aiohttp sessions to specific base URL.
+- index: Do not deserialize originations matched by the `source` filter.
+- index: Wrap storage deserialization exceptions with `InvalidDataError`.
+- projects: Fixed Hasura environment in docker-compose examples.
+
+### Other
+
+- ci: `mypy --strict` is now enforced on a codebase.
+- ci: Finished migration to `pytest`.
 
 ### Security
 
@@ -831,7 +840,8 @@ This release contains no changes except for the version number.
 [semantic versioning]: https://semver.org/spec/v2.0.0.html
 
 <!-- Versions -->
-[Unreleased]: https://github.com/dipdup-io/dipdup/compare/6.3.0...HEAD
+[Unreleased]: https://github.com/dipdup-io/dipdup/compare/6.3.1...HEAD
+[6.3.1]: https://github.com/dipdup-io/dipdup/compare/6.3.0...6.3.1
 [6.3.0]: https://github.com/dipdup-io/dipdup/compare/6.2.0...6.3.0
 [6.2.0]: https://github.com/dipdup-io/dipdup/compare/6.1.3...6.2.0
 [6.1.3]: https://github.com/dipdup-io/dipdup/compare/6.1.2...6.1.3

Makefile

@@ -30,9 +30,6 @@ lint:           ## Lint with all tools
 test:           ## Run test suite
 	poetry run pytest --cov-report=term-missing --cov=dipdup --cov-report=xml -n auto -s -v tests
 
-test-ci:        ## Run test suite without xdist, coverage and some tests (avoid macOS issues)
-	CI=true poetry run pytest -s -v tests
-
 docs:           ## Build docs
 	scripts/update_cookiecutter.py
 	cd docs
@@ -50,7 +47,7 @@ flake:          ## Lint with flake8
 	poetry run flakeheaven lint src tests scripts
 
 mypy:           ## Lint with mypy
-	poetry run mypy src tests scripts
+	poetry run mypy --strict src tests scripts
 
 cover:          ## Print coverage for the current branch
 	poetry run diff-cover --compare-branch `git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@'` coverage.xml
@@ -121,6 +118,7 @@ update:         ## Update dependencies, export requirements.txt
 scripts:
 	python scripts/update_cookiecutter.py
 	python scripts/update_demos.py
-	make lint
+	rm -r tests/replays/*
+	make lint test
 
 ##

demos/demo-domains-big-map/docker-compose.swarm.yml

@@ -57,7 +57,7 @@ services:
     depends_on:
       - db
     environment:
-      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432/dipdup
+      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432
       - HASURA_GRAPHQL_ENABLE_CONSOLE=true
       - HASURA_GRAPHQL_DEV_MODE=false
       - HASURA_GRAPHQL_ENABLED_LOG_TYPES=startup, http-log, websocket-log, query-log

demos/demo-domains-big-map/docker-compose.yml

@@ -38,7 +38,7 @@ services:
       - db
     restart: always
     environment:
-      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432/dipdup
+      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432
       - HASURA_GRAPHQL_ENABLE_CONSOLE=true
       - HASURA_GRAPHQL_DEV_MODE=true
       - HASURA_GRAPHQL_ENABLED_LOG_TYPES=startup, http-log, webhook-log, websocket-log, query-log

demos/demo-domains-big-map/src/demo_domains_big_map/hooks/on_index_rollback.py

@@ -4,7 +4,7 @@
 
 async def on_index_rollback(
     ctx: HookContext,
-    index: Index,
+    index: Index,  # type: ignore[type-arg]
     from_level: int,
     to_level: int,
 ) -> None:

demos/demo-domains-big-map/src/demo_domains_big_map/models.py

@@ -1,5 +1,5 @@
-from tortoise import ForeignKeyFieldInstance
 from tortoise import fields
+from tortoise.fields.relational import ForeignKeyFieldInstance
 
 from dipdup.models import Model
 

demos/demo-domains/docker-compose.swarm.yml

@@ -57,7 +57,7 @@ services:
     depends_on:
       - db
     environment:
-      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432/dipdup
+      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432
       - HASURA_GRAPHQL_ENABLE_CONSOLE=true
       - HASURA_GRAPHQL_DEV_MODE=false
       - HASURA_GRAPHQL_ENABLED_LOG_TYPES=startup, http-log, websocket-log, query-log

demos/demo-domains/docker-compose.yml

@@ -38,7 +38,7 @@ services:
       - db
     restart: always
     environment:
-      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432/dipdup
+      - HASURA_GRAPHQL_DATABASE_URL=postgres://dipdup:${POSTGRES_PASSWORD:-changeme}@db:5432
       - HASURA_GRAPHQL_ENABLE_CONSOLE=true
       - HASURA_GRAPHQL_DEV_MODE=true
       - HASURA_GRAPHQL_ENABLED_LOG_TYPES=startup, http-log, webhook-log, websocket-log, query-log

demos/demo-domains/src/demo_domains/hooks/on_index_rollback.py

@@ -4,7 +4,7 @@
 
 async def on_index_rollback(
     ctx: HookContext,
-    index: Index,
+    index: Index,  # type: ignore[type-arg]
     from_level: int,
     to_level: int,
 ) -> None:

demos/demo-domains/src/demo_domains/models.py

@@ -1,7 +1,7 @@
 from typing import Optional
 
-from tortoise import ForeignKeyFieldInstance
 from tortoise import fields
+from tortoise.fields.relational import ForeignKeyFieldInstance
 
 from dipdup.models import Model