Skip to content

Commit df08b4e

Browse files
droserasproutWizard1209
andauthored
Don't notify about new framework versions available (#1285)
Co-authored-by: Wizard1209 <[email protected]>
1 parent 06c8983 commit df08b4e

File tree

6 files changed

+6
-122
lines changed

6 files changed

+6
-122
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog], and this project adheres to [Semantic
66

77
Releases prior to 7.0 has been removed from this file to declutter search results; see the [archived copy](https://github.com/dipdup-io/dipdup/blob/8.0.0b5/CHANGELOG.md) for the full list.
88

9+
## [Unreleased]
10+
11+
### Changed
12+
13+
- cli: Don't notify about new framework versions available.
14+
915
## [8.5.0] - 2025-09-14
1016

1117
### Added

docs/5.advanced/_env_table.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
| `DIPDUP_NO_BASE` | Don't recreate files from base project template |
1111
| `DIPDUP_NO_HOOKS` | Don't run hooks, both internal and user-defined |
1212
| `DIPDUP_NO_SYMLINK` | Don't create magic symlink in the package root even when used as cwd |
13-
| `DIPDUP_NO_VERSION_CHECK` | Disable warning about running unstable or out-of-date DipDup version |
1413
| `DIPDUP_PACKAGE_PATH` | Disable package discovery and use the specified path |
1514
| `DIPDUP_REPLAY_PATH` | Path to datasource replay files; used in tests (dev only) |
1615
| `DIPDUP_TEST` | Running in tests (disables Sentry and some checks) |

src/dipdup/_version.py

Lines changed: 0 additions & 108 deletions
This file was deleted.

src/dipdup/cli.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,13 +322,6 @@ async def cli(ctx: click.Context, config: list[str], env_file: list[str], c: lis
322322
# NOTE: Imports will be loaded later if needed
323323
_config.initialize()
324324

325-
# NOTE: Fire and forget, do not block instant commands
326-
if not (env.TEST or env.is_in_gha() or env.NO_VERSION_CHECK):
327-
from dipdup._version import check_version
328-
329-
# FIXME: https://github.com/dipdup-io/dipdup/issues/1114; replace with `fire_and_forget` call once resolved.
330-
await check_version()
331-
332325
try:
333326
# NOTE: Avoid early import errors if project package is incomplete.
334327
# NOTE: `ConfigurationError` will be raised later with more details.

src/dipdup/env.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ def reload_env() -> None:
9393
NO_BASE, \
9494
NO_HOOKS, \
9595
NO_SYMLINK, \
96-
NO_VERSION_CHECK, \
9796
PACKAGE_PATH, \
9897
REPLAY_PATH, \
9998
TEST
@@ -107,7 +106,6 @@ def reload_env() -> None:
107106
NO_BASE = get_bool('DIPDUP_NO_BASE')
108107
NO_HOOKS = get_bool('DIPDUP_NO_HOOKS')
109108
NO_SYMLINK = get_bool('DIPDUP_NO_SYMLINK')
110-
NO_VERSION_CHECK = get_bool('DIPDUP_NO_VERSION_CHECK')
111109
PACKAGE_PATH = get_path('DIPDUP_PACKAGE_PATH')
112110
REPLAY_PATH = get_path('DIPDUP_REPLAY_PATH')
113111
TEST = get_bool('DIPDUP_TEST')
@@ -156,9 +154,6 @@ def extract_docstrings() -> dict[str, str]:
156154
NO_SYMLINK: bool = get_bool('DIPDUP_NO_SYMLINK')
157155
"""Don't create magic symlink in the package root even when used as cwd"""
158156

159-
NO_VERSION_CHECK: bool = get_bool('DIPDUP_NO_VERSION_CHECK')
160-
"""Disable warning about running unstable or out-of-date DipDup version"""
161-
162157
PACKAGE_PATH: Path | None = get_path('DIPDUP_PACKAGE_PATH')
163158
"""Disable package discovery and use the specified path"""
164159

src/dipdup/test.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ async def tmp_project(
181181
'PYTHONPATH': str(tmp_package_path),
182182
'DIPDUP_TEST': '1',
183183
'DIPDUP_DEBUG': '1',
184-
'DIPDUP_NO_VERSION_CHECK': '1',
185184
}
186185

187186
yield Path(tmp_package_path), env

0 commit comments

Comments
 (0)