Skip to content

Commit 3f47a9b

Browse files
committed
Refactor MakeComments with moving field commenting logic to separate method.
1 parent 0754e20 commit 3f47a9b

File tree

1 file changed

+22
-28
lines changed

1 file changed

+22
-28
lines changed

database/comment.go

Lines changed: 22 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -52,24 +52,10 @@ func MakeComments(ctx context.Context, sc SchemeCommenter, models ...interface{}
5252
if err := makeEmbeddedComments(ctx, sc, tableName, fieldType.Type); err != nil {
5353
return err
5454
}
55-
}
56-
57-
comment, ok := getComment(fieldType)
58-
if !ok || comment == "" {
5955
continue
6056
}
6157

62-
columnName, ok := getPgName(fieldType)
63-
64-
if columnName == "-" {
65-
continue
66-
}
67-
68-
if !ok {
69-
columnName = hasura.ToSnakeCase(fieldType.Name)
70-
}
71-
72-
if err := sc.MakeColumnComment(ctx, tableName, columnName, comment); err != nil {
58+
if err := makeFieldComment(ctx, sc, tableName, fieldType); err != nil {
7359
return err
7460
}
7561
}
@@ -85,24 +71,32 @@ func makeEmbeddedComments(ctx context.Context, sc SchemeCommenter, tableName str
8571
return errors.New("Embedded type must not have tableName field.")
8672
}
8773

88-
comment, ok := getComment(fieldType)
89-
if !ok || comment == "" {
90-
continue
74+
if err := makeFieldComment(ctx, sc, tableName, fieldType); err != nil {
75+
return err
9176
}
77+
}
78+
79+
return nil
80+
}
9281

93-
columnName, ok := getPgName(fieldType)
82+
func makeFieldComment(ctx context.Context, sc SchemeCommenter, tableName string, fieldType reflect.StructField) error {
83+
comment, ok := getComment(fieldType)
84+
if !ok || comment == "" {
85+
return nil
86+
}
9487

95-
if columnName == "-" {
96-
continue
97-
}
88+
columnName, ok := getPgName(fieldType)
9889

99-
if !ok {
100-
columnName = hasura.ToSnakeCase(fieldType.Name)
101-
}
90+
if columnName == "-" {
91+
return nil
92+
}
10293

103-
if err := sc.MakeColumnComment(ctx, tableName, columnName, comment); err != nil {
104-
return err
105-
}
94+
if !ok {
95+
columnName = hasura.ToSnakeCase(fieldType.Name)
96+
}
97+
98+
if err := sc.MakeColumnComment(ctx, tableName, columnName, comment); err != nil {
99+
return err
106100
}
107101

108102
return nil

0 commit comments

Comments
 (0)