Merge pull request #17 from dipdup-io/fix-make-comments-models-validation

Author: vvuwei

database/comment.go

@@ -8,7 +8,15 @@ import (
 )
 
 func MakeComments(ctx context.Context, sc SchemeCommenter, models ...interface{}) error {
+	if models == nil {
+		return nil
+	}
+
 	for _, model := range models {
+		if model == nil {
+			continue
+		}
+
 		modelType := reflect.TypeOf(model)
 
 		if reflect.ValueOf(model).Kind() == reflect.Ptr {

database/comment_test.go

@@ -262,3 +262,37 @@ func TestMakeCommentsIgnoreFieldsWithEmptyComment(t *testing.T) {
 	// Assert
 	assert.Empty(t, err)
 }
+
+func TestMakeCommentsIgnoreNilModel(t *testing.T) {
+	mockCtrl, mockSC, ctx := initMocks(t)
+	defer mockCtrl.Finish()
+
+	// Assert prepare
+	mockSC.
+		EXPECT().
+		MakeColumnComment(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).
+		Times(0)
+
+	// Act
+	err := MakeComments(ctx, mockSC, nil)
+
+	// Assert
+	assert.Empty(t, err)
+}
+
+func TestMakeCommentsIgnoreNoModels(t *testing.T) {
+	mockCtrl, mockSC, ctx := initMocks(t)
+	defer mockCtrl.Finish()
+
+	// Assert prepare
+	mockSC.
+		EXPECT().
+		MakeColumnComment(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).
+		Times(0)
+
+	// Act
+	err := MakeComments(ctx, mockSC)
+
+	// Assert
+	assert.Empty(t, err)
+}