Skip to content

Commit 0af035b

Browse files
committed
Remove undefined check for minSize
It has a default value
1 parent 9e23d59 commit 0af035b

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

packages/vue-split-panel/src/composables/use-sizes.test.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -117,12 +117,6 @@ describe('useSizes', () => {
117117
});
118118

119119
describe('minSizePercentage', () => {
120-
it('should return undefined when minSize is undefined', () => {
121-
const options = { ...defaultOptions, minSize: undefined };
122-
const { minSizePercentage } = useSizes(size, options);
123-
expect(minSizePercentage.value).toBeUndefined();
124-
});
125-
126120
it('should return minSize value when sizeUnit is percentage', () => {
127121
const { minSizePercentage } = useSizes(size, defaultOptions);
128122
expect(minSizePercentage.value).toBe(10);
@@ -136,12 +130,6 @@ describe('useSizes', () => {
136130
});
137131

138132
describe('minSizePixels', () => {
139-
it('should return undefined when minSize is undefined', () => {
140-
const options = { ...defaultOptions, minSize: undefined };
141-
const { minSizePixels } = useSizes(size, options);
142-
expect(minSizePixels.value).toBeUndefined();
143-
});
144-
145133
it('should return minSize value when sizeUnit is pixels', () => {
146134
const options = { ...defaultOptions, sizeUnit: 'px' as const, minSize: 40 };
147135
const { minSizePixels } = useSizes(size, options);

packages/vue-split-panel/src/composables/use-sizes.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export interface UseSizesOptions {
1212
primary: MaybeRefOrGetter<Primary | undefined>;
1313
orientation: MaybeRefOrGetter<Orientation>;
1414
sizeUnit: MaybeRefOrGetter<SizeUnit>;
15-
minSize: MaybeRefOrGetter<number | undefined>;
15+
minSize: MaybeRefOrGetter<number>;
1616
maxSize: MaybeRefOrGetter<number | undefined>;
1717
snapPoints: MaybeRefOrGetter<number[]>;
1818
panelEl: MaybeComputedElementRef;
@@ -57,15 +57,11 @@ export const useSizes = (size: Ref<number>, options: UseSizesOptions) => {
5757
});
5858

5959
const minSizePercentage = computed(() => {
60-
if (toValue(options.minSize) === undefined) return;
61-
6260
if (toValue(options.sizeUnit) === '%') return toValue(options.minSize);
6361
return pixelsToPercentage(componentSize.value, toValue(options.minSize));
6462
});
6563

6664
const minSizePixels = computed(() => {
67-
if (toValue(options.minSize) === undefined) return;
68-
6965
if (toValue(options.sizeUnit) === 'px') return toValue(options.minSize);
7066
return percentageToPixels(componentSize.value, toValue(options.minSize));
7167
});

0 commit comments

Comments
 (0)