Fix linker flags quoting for macOS static builds

Author: dirkvdb

CMakeLists.txt

@@ -37,6 +37,7 @@ option(ENABLE_STATIC "Build static library" OFF)
 option(ENABLE_TESTS "Build unit tests" ON)
 option(ENABLE_GIO "Support for gio file uris" OFF)
 option(ENABLE_THUMBNAILER "Register ffmpegthumbnailer as thumbnailer" OFF)
+option(ENABLE_FULL_STATIC "Build fully static binary" OFF)
 option(SANITIZE_ADDRESS "Build with address sanitizer (detect invalid memory access and memory leaks)" OFF)
 
 if (SANITIZE_ADDRESS)

cmake/FindFFmpeg.cmake

@@ -51,10 +51,7 @@ mark_as_advanced(
 )
 
 # Determine if we need static linking
-set(FFMPEG_USE_STATIC_LIBS OFF)
-if(NOT BUILD_SHARED_LIBS OR ENABLE_STATIC)
-    set(FFMPEG_USE_STATIC_LIBS ON)
-endif()
+set(FFMPEG_USE_STATIC_LIBS ${ENABLE_FULL_STATIC})
 
 message(STATUS "FFmpeg found: ${FFmpeg_FOUND}")
 message(STATUS "  avcodec:  ${AVCODEC_LIBRARY_PATH}")
@@ -115,6 +112,11 @@ if(FFmpeg_FOUND AND NOT TARGET FFmpeg::avcodec)
             INTERFACE_LINK_DIRECTORIES "${AVCODEC_STATIC_LIBRARY_DIRS}")
         set_property(TARGET FFmpeg::avcodec APPEND PROPERTY
             INTERFACE_LINK_LIBRARIES "${AVCODEC_STATIC_LIBRARIES}")
+
+        if(APPLE)
+            set_property(TARGET FFmpeg::avcodec APPEND PROPERTY
+                INTERFACE_LINK_LIBRARIES "-framework CoreVideo" "-framework CoreImage" "-framework VideoToolbox")
+        endif()
     endif()
 endif()
 

flake.nix

@@ -169,8 +169,8 @@
               ++ pkgsForHost.lib.optionals (isStatic && !isWindows && pkgsForHost.stdenv.isLinux) [
                 "-DCMAKE_EXE_LINKER_FLAGS=-static"
               ]
-              ++ pkgsForHost.lib.optionals (isStatic && pkgsForHost.stdenv.isDarwin) [
-                "-DCMAKE_EXE_LINKER_FLAGS=-framework CoreVideo;-framework VideoToolbox"
+              ++ pkgsForHost.lib.optionals isStatic [
+                "-DENABLE_FULL_STATIC=ON"
               ]
               ++ pkgsForHost.lib.optionals (pkgsForHost.stdenv.isLinux && !isStatic && !isWindows) [
                 "-DENABLE_GIO=ON"