fix(voice): fixed disconnects not actually removing the bot from the channel

This is because the main gateway, not the voice gateway, wasn't being informed of the leaving with a voice state update payload. This is unfortuantley not very well documented in the Discord API docs...

Author: seailz

src/main/java/com/seailz/discordjar/gateway/Gateway.java

@@ -482,6 +482,19 @@ public void sendVoicePayload(String guildId, String channelId, boolean selfMute,
         queueMessage(payload);
     }
 
+    // Leaves the voice channel
+    public void sendVoicePayloadToLeave(String guildId) {
+        JSONObject payload = new JSONObject();
+        JSONObject dPayload = new JSONObject();
+        dPayload.put("guild_id", guildId);
+        dPayload.put("channel_id", JSONObject.NULL);
+        dPayload.put("self_mute", false);
+        dPayload.put("self_deaf", false);
+        payload.put("op", OpCodes.VOICE_STATE_UPDATE.opCode);
+        payload.put("d", dPayload);
+        queueMessage(payload);
+    }
+
     public void onVoiceStateUpdate(Consumer<VoiceState> consumer) {
         onVoiceStateUpdateListeners.add(consumer);
     }

src/main/java/com/seailz/discordjar/model/channel/internal/AudioChannelImpl.java

@@ -75,9 +75,8 @@ public void connect(VoiceProvider vp, boolean mute, boolean deafen) {
                 }
 
                 if (receivedVoiceServerUpdate.get() && receivedVoiceStateUpdate.get()) {
-                    System.out.println("Establishing Voice WS Connection");
                     try {
-                        VoiceGatewayFactory voiceGateway = new VoiceGatewayFactory(guild().id(), discordJv().getSelfUser().id(), sessionId.get(), token.get(), endpoint.get(), vp);
+                        VoiceGatewayFactory voiceGateway = new VoiceGatewayFactory(guild().id(), discordJv().getSelfUser().id(), sessionId.get(), token.get(), endpoint.get(), vp, discordJv());
                         break;
                     } catch (ExecutionException | InterruptedException e) {
                         throw new RuntimeException(e);

src/main/java/com/seailz/discordjar/voice/udp/VoiceUDP.java

@@ -123,8 +123,9 @@ public void start() throws IOException {
     }
 
     public void disconnect() {
-        voiceGateway.close(1001);
+        voiceGateway.close(1000);
         socket.disconnect();
+        voiceGateway.getJar().getGateway().sendVoicePayloadToLeave(voiceGateway.getServerId());
     }
 
     public void stop() {

src/main/java/com/seailz/discordjar/voice/ws/VoiceGatewayFactory.java

@@ -2,9 +2,11 @@
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.seailz.discordjar.DiscordJar;
 import com.seailz.discordjar.voice.model.packet.AudioPacket;
 import com.seailz.discordjar.voice.model.provider.VoiceProvider;
 import com.seailz.discordjar.voice.udp.VoiceUDP;
+import lombok.Getter;
 import org.json.JSONArray;
 import org.json.JSONObject;
 import org.springframework.web.socket.CloseStatus;
@@ -28,6 +30,7 @@
 // TODO: at some point this should be converted to use the WebSocket class
 public class VoiceGatewayFactory extends TextWebSocketHandler {
 
+    @Getter
     private final String serverId;
     private final String userId;
     private final String sessionId;
@@ -43,13 +46,17 @@ public class VoiceGatewayFactory extends TextWebSocketHandler {
     private boolean speaking = true;
     private VoiceUDP socket;
 
-    public VoiceGatewayFactory(String serverId, String userId, String sessionId, String token, String endpoint, VoiceProvider prov) throws ExecutionException, InterruptedException {
+    @Getter
+    private DiscordJar jar;
+
+    public VoiceGatewayFactory(String serverId, String userId, String sessionId, String token, String endpoint, VoiceProvider prov, DiscordJar jar) throws ExecutionException, InterruptedException {
         this.serverId = serverId;
         this.userId = userId;
         this.sessionId = sessionId;
         this.token = token;
         this.provider = prov;
         connect(endpoint);
+        this.jar = jar;
     }
 
     public void connect(String endpoint) throws ExecutionException, InterruptedException {