Static modifier on some $allowed arrays

This patch is targeted at the compiler, allowing these functions to be processed faster by referencing the arrays without expecting change for them, thus being more computationally and memory efficient

Author: valzargaming

src/Discord/Builders/CommandAttributes.php

@@ -323,7 +323,7 @@ public function addIntegrationType(int $integration_type): self
             throw new \DomainException('Only globally-scopped commands can have an integration type.');
         }
 
-        $allowed = [
+        static $allowed = [
             Application::INTEGRATION_TYPE_GUILD_INSTALL,
             Application::INTEGRATION_TYPE_USER_INSTALL,
         ];
@@ -377,7 +377,7 @@ public function addContext(int $context): self
             throw new \DomainException('Only globally-scopped commands can have context.');
         }
 
-        $allowed = [
+        static $allowed = [
             Interaction::CONTEXT_TYPE_GUILD,
             Interaction::CONTEXT_TYPE_BOT_DM,
             Interaction::CONTEXT_TYPE_PRIVATE_CHANNEL,
@@ -451,7 +451,7 @@ public function setHandler(?int $handler): self
             throw new \DomainException('Only PRIMARY_ENTRY_POINT Command type can have handler.');
         }
 
-        $allowed = [Command::APP_HANDLER, Command::DISCORD_LAUNCH_ACTIVITY];
+        static $allowed = [Command::APP_HANDLER, Command::DISCORD_LAUNCH_ACTIVITY];
 
         if (is_int($handler) && ! in_array($handler, $allowed)) {
             throw new \DomainException('Invalid handler provided.');

src/Discord/Builders/Components/SelectMenu.php

@@ -150,7 +150,7 @@ public static function new(?string $custom_id = null): self
      */
     public function setType(int $type): self
     {
-        $allowed_types = [self::TYPE_STRING_SELECT, self::TYPE_USER_SELECT, self::TYPE_ROLE_SELECT, self::TYPE_MENTIONABLE_SELECT, self::TYPE_CHANNEL_SELECT];
+        static $allowed_types = [self::TYPE_STRING_SELECT, self::TYPE_USER_SELECT, self::TYPE_ROLE_SELECT, self::TYPE_MENTIONABLE_SELECT, self::TYPE_CHANNEL_SELECT];
         if (! in_array($type, $allowed_types)) {
             throw new \InvalidArgumentException('Invalid select menu type.');
         }
@@ -245,7 +245,7 @@ public function setPlaceholder(?string $placeholder): self
 
     public function setDefaultValues(?array $default_values): self
     {
-        $allowed_types = [self::TYPE_USER_SELECT, self::TYPE_ROLE_SELECT, self::TYPE_MENTIONABLE_SELECT, self::TYPE_CHANNEL_SELECT];
+        static $allowed_types = [self::TYPE_USER_SELECT, self::TYPE_ROLE_SELECT, self::TYPE_MENTIONABLE_SELECT, self::TYPE_CHANNEL_SELECT];
         if (! in_array($this->type, $allowed_types)) {
             throw new \InvalidArgumentException('Default values can only be set for user, role, mentionable, and channel selects.');
         }

src/Discord/CommandClient/Command.php

@@ -311,7 +311,7 @@ public function getHelp(string $prefix): array
      */
     public function __get(string $variable)
     {
-        $allowed = ['command', 'description', 'longDescription', 'usage', 'cooldown', 'cooldownMessage', 'showHelp'];
+        static $allowed = ['command', 'description', 'longDescription', 'usage', 'cooldown', 'cooldownMessage', 'showHelp'];
 
         if (in_array($variable, $allowed)) {
             return $this->{$variable};

src/Discord/Discord.php

@@ -1225,7 +1225,7 @@ public function updatePresence(?Activity $activity = null, bool $idle = false, s
             }
         }
 
-        $allowed = ['online', 'dnd', 'idle', 'invisible', 'offline'];
+        static $allowed = ['online', 'dnd', 'idle', 'invisible', 'offline'];
 
         if (! in_array($status, $allowed)) {
             $status = 'online';
@@ -1685,7 +1685,7 @@ public function getCacheConfig($repository_class = AbstractRepository::class)
      */
     public function __get(string $name)
     {
-        $allowed = ['loop', 'options', 'logger', 'http', 'application_commands'];
+        static $allowed = ['loop', 'options', 'logger', 'http', 'application_commands'];
 
         if (in_array($name, $allowed)) {
             return $this->{$name};

src/Discord/DiscordCommandClient.php

@@ -476,7 +476,7 @@ public function getCommandClientOptions()
      */
     public function __get(string $name)
     {
-        $allowed = ['commands', 'aliases'];
+        static $allowed = ['commands', 'aliases'];
 
         if (in_array($name, $allowed)) {
             return $this->{$name};

src/Discord/Parts/Channel/Message/AllowedMentions.php

@@ -132,7 +132,7 @@ public function setParse($items): self
      */
     public function addParse(...$items): self
     {
-        $allowed = [self::TYPE_ROLE, self::TYPE_USER, self::TYPE_EVERYONE];
+        static $allowed = [self::TYPE_ROLE, self::TYPE_USER, self::TYPE_EVERYONE];
 
         foreach ($items as &$item) {
             if (!is_string($item)) {

src/Discord/Parts/Guild/Guild.php

@@ -520,7 +520,7 @@ public function getIconAttribute(?string $format = null, int $size = 1024): ?str
         }
 
         if (isset($format)) {
-            $allowed = ['png', 'jpg', 'webp', 'gif'];
+            static $allowed = ['png', 'jpg', 'webp', 'gif'];
 
             if (! in_array(strtolower($format), $allowed)) {
                 $format = 'webp';
@@ -558,7 +558,7 @@ public function getSplashAttribute(string $format = 'webp', int $size = 2048): ?
             return null;
         }
 
-        $allowed = ['png', 'jpg', 'webp'];
+        static $allowed = ['png', 'jpg', 'webp'];
 
         if (! in_array(strtolower($format), $allowed)) {
             $format = 'webp';

src/Discord/Parts/Guild/Role.php

@@ -111,7 +111,7 @@ public function getIconAttribute(string $format = 'png', int $size = 64): ?strin
             return null;
         }
 
-        $allowed = ['png', 'jpg', 'webp'];
+        static $allowed = ['png', 'jpg', 'webp'];
 
         if (! in_array(strtolower($format), $allowed)) {
             $format = 'png';

src/Discord/Parts/Guild/ScheduledEvent.php

@@ -192,7 +192,7 @@ public function getImageAttribute(?string $format = null, int $size = 1024): ?st
             return null;
         }
 
-        $allowed = ['png', 'jpg', 'webp'];
+        static $allowed = ['png', 'jpg', 'webp'];
 
         if (! in_array(strtolower($format), $allowed)) {
             $format = 'png';

src/Discord/Parts/OAuth/Application.php

@@ -188,7 +188,7 @@ public function getIconAttribute(string $format = 'webp', int $size = 1024): ?st
             return null;
         }
 
-        $allowed = ['png', 'jpg', 'webp'];
+        static $allowed = ['png', 'jpg', 'webp'];
         if (! in_array(strtolower($format), $allowed)) {
             $format = 'webp';
         }
@@ -256,7 +256,7 @@ public function getCoverImageAttribute(string $format = 'webp', int $size = 1024
             return null;
         }
 
-        $allowed = ['png', 'jpg', 'webp'];
+        static $allowed = ['png', 'jpg', 'webp'];
         if (! in_array(strtolower($format), $allowed)) {
             $format = 'webp';
         }