$channel->members should actually return members

Author: valzargaming

src/Discord/Parts/Channel/Channel.php

@@ -89,7 +89,7 @@
  * @property InviteRepository        $invites         Invites in the channel.
  * @property StageInstanceRepository $stage_instances Stage instances in the channel.
  *
- * @property ExCollectionInterface<VoiceStateUpdate>|VoiceStateUpdate[] $members If voice channel, the members currently in the channel.
+ * @property ExCollectionInterface<Member>|Member[] $members If voice channel, the members currently in the channel.
  */
 class Channel extends Part implements Stringable
 {
@@ -1042,16 +1042,15 @@ public function startThread(array|string $options, string|bool|null $reason = nu
     /**
      * Gets the members currently in the voice channel.
      *
-     * @return ExCollectionInterface<VoiceStateUpdate>|VoiceStateUpdate[] Members in the voice channel.
+     * @return ExCollectionInterface<Member>|Member[] Members in the voice channel.
      */
     public function getMembersAttribute(): ExCollectionInterface
     {
         if ($guild = $this->guild) {
-            return $guild->voice_states->filter(fn (VoiceStateUpdate $voice_state) => $voice_state->channel_id === $this->id);
+            return $guild->members->filter(fn (Member $member) => $guild->voice_states->filter(fn (VoiceStateUpdate $voice_state) => $voice_state->channel_id === $this->id)->has($member->id));
         }
 
-        /** @var ExCollectionInterface<VoiceStateUpdate> */
-        return $this->discord->getCollectionClass()::for(VoiceStateUpdate::class, 'user_id');
+        return $this->discord->getCollectionClass()::for(Member::class, 'id');
     }
 
     /**

src/Discord/Parts/Channel/ChannelTrait.php

@@ -57,9 +57,9 @@
  * @property      string       $parent_id           The ID of the parent channel or the channel which the thread was started in.
  * @property-read Channel|null $parent              The parent channel or the channel which the thread was created in.
  *
- * @property bool                                                       $is_private Whether the channel is a private channel.
- * @property ExCollectionInterface<VoiceStateUpdate>|VoiceStateUpdate[] $members    Voice channel only - members in the channel or thread.
- * @property MessageRepository                                          $messages   Text channel only - messages sent in the channel or thread.
+ * @property bool                                   $is_private Whether the channel is a private channel.
+ * @property ExCollectionInterface<Member>|Member[] $members    Voice channel only - members in the channel or thread.
+ * @property MessageRepository                      $messages   Text channel only - messages sent in the channel or thread.
  *
  * @property Discord $discord The Discord client instance.
  */