fixed LinkButton + removed decompressing + other

Author: kvsxxx

README.md

@@ -176,6 +176,23 @@ You can find more (and better) examples [here](https://github.com/discord-py-ui/
 
 # Changelog
 
+-   <details>
+    <summary>4.3.7</summary>
+
+    ## **Changed**
+    - SlashOption
+    > Required is now ``True`` by default
+
+    ## **Fixed**
+    - `AttributeError: 'LinkButton' object has no attribute 'component_type'`
+
+    ## **Removed**
+    - decompressing
+    > The lib now doesn't decompress byte data anymore, which means everything before the dpy commit `848d752` doesn't work with this lib 
+    > [message reference](https://discord.com/channels/336642139381301249/381965829857738772/879980113742143548) in discordpy discord server
+
+    </details>
+
 -   <details>
     <summary>4.3.6</summary>
 

discord_ui/__init__.py

@@ -46,4 +46,4 @@
 
 
 __title__ = "discord-ui"
-__version__ = "4.3.6"
+__version__ = "4.3.7"

discord_ui/client.py

@@ -96,8 +96,9 @@ def __init__(self, client, parse_method = ParseMethod.AUTO, auto_sync=True, dele
         Slash(client)
         ```
         """
-        self._buffer = bytearray()
-        self._zlib = zlib.decompressobj()
+        # disable decompressing
+        # self._buffer = bytearray()
+        # self._zlib = zlib.decompressobj()
 
         self.ready = False
         self.parse_method: int = parse_method
@@ -148,18 +149,19 @@ async def on_connect():
 
     async def _on_slash_response(self, msg):
         if discord.__version__.startswith("2"):
-            if isinstance(msg, bytes):
-                try:
-                    self._buffer.extend(msg)
-                    if len(msg) < 4 or msg[-4:] != b'\x00\x00\xff\xff':
-                        return
-                    msg = self._zlib.decompress(self._buffer)
-                    msg = msg.decode('utf-8')
-                    self._buffer = bytearray()
-                except:
-                    return
-        if isinstance(msg, str):
-            msg = json.loads(msg)
+            # comment decompressing out in canse it is needed in the future for some reason
+            # if isinstance(msg, bytes):
+            #     try:
+            #         self._buffer.extend(msg)
+            #         if len(msg) < 4 or msg[-4:] != b'\x00\x00\xff\xff':
+            #             return
+            #         msg = self._zlib.decompress(self._buffer)
+            #         msg = msg.decode('utf-8')
+            #         self._buffer = bytearray()
+            #     except:
+            #         return
+            if isinstance(msg, str):
+                msg = json.loads(msg)
 
         if msg["t"] != "INTERACTION_CREATE":
             return
@@ -1268,8 +1270,9 @@ def __init__(self, client: com.Bot, override_dpy=True, auto_defer=False):
         if override_dpy:
             override_it()
 
-        self._buffer = bytearray()
-        self._zlib = zlib.decompressobj()
+        # disable decompressing
+        # self._buffer = bytearray()
+        # self._zlib = zlib.decompressobj()
 
         self.auto_defer: Tuple[bool, bool] = (auto_defer, False) if isinstance(auto_defer, bool) else auto_defer
         self.listening_components: Dict[str, List[ListeningComponent]] = {}
@@ -1303,14 +1306,15 @@ def remove_cog_override(*args, **kwargs):
 
     async def _on_component_response(self, msg):
         if discord.__version__.startswith("2"):
-            if isinstance(msg, bytes):
-                self._buffer.extend(msg)
-
-                if len(msg) < 4 or msg[-4:] != b'\x00\x00\xff\xff':
-                    return
-                msg = self._zlib.decompress(self._buffer)
-                msg = msg.decode('utf-8')
-                self._buffer = bytearray()
+        # disable deecompressing
+        #     if isinstance(msg, bytes):
+        #         self._buffer.extend(msg)
+
+        #         if len(msg) < 4 or msg[-4:] != b'\x00\x00\xff\xff':
+        #             return
+        #         msg = self._zlib.decompress(self._buffer)
+        #         msg = msg.decode('utf-8')
+        #         self._buffer = bytearray()
             if isinstance(msg, str):
                 msg = json.loads(msg)
 

discord_ui/components.py

@@ -365,7 +365,7 @@ def to_dict(self) -> dict:
             payload["placeholder"] = self.placeholder
         return payload
 
-class BaseButton():
+class BaseButton(Component):
     def __init__(self, label, color, emoji, new_line, disabled) -> None:
         Component.__init__(self, ComponentType.Button)
         if label is None and emoji is None:
@@ -555,7 +555,7 @@ def __init__(self, url, label="\u200b", emoji=None, new_line=False, disabled=Fal
         LinkButton("https://discord.com/", "press me (if you can)!", emoji="😀", disabled=True)
         ```
         """
-        BaseButton.__init__(self, label, ButtonStyles.url, emoji, new_line, disabled) 
+        BaseButton.__init__(self, label, ButtonStyles.url, emoji, new_line, disabled)
         self._url = None
         self.url = url
 

discord_ui/slash/types.py

@@ -24,7 +24,7 @@ class SlashOption():
         description: :class:`str`, optional
             1-100 character description of the command; default name
         required: :class:`bool`, optional
-            If the parameter is required or optional; default False
+            If the parameter is required or optional; default True
         choices: List[:class:`dict`], optional
             Choices for string and int types for the user to pick from; default None
                 Choices should be formated like this: ``[{"name": "name of the choice", "value": "the real value"}, ...]``
@@ -36,7 +36,7 @@ class SlashOption():
         options: List[:class:`~SlashOption`]
             This parameter is only for subcommands to work, you shouldn't need to use that, unless you know what you're doing 
         """
-    def __init__(self, argument_type, name, description=None, required=False, choices=None, options=None) -> None:
+    def __init__(self, argument_type, name, description=None, required=True, choices=None, options=None) -> None:
         """
         Creates a new option for a slash command
 
@@ -49,7 +49,7 @@ def __init__(self, argument_type, name, description=None, required=False, choice
         self.argument_type = argument_type
         self.name = name
         self.description = _or(description, self.name)
-        self.required = _default([], required)
+        self.required = required
         self.options = _default([], options)
         self.choices = _default([], choices)
     def __repr__(self) -> str: