fixed #89 again and fixed on_cog_sync warning

Author: kvsxxx

README.md

@@ -175,6 +175,14 @@ You can find more (and better) examples [here](https://github.com/discord-py-ui/
 
 # Changelog
 
+-   <details>
+    
+    ## **Fixed**
+
+    - #94 (again 💀)
+
+    </details>
+
 -   <details>
     <summary>4.2.7<summary>
 

discord_ui/client.py

@@ -6,7 +6,7 @@
 from .slash.tools import ParseMethod, cache_data, format_name, handle_options, handle_thing
 from .slash.http import create_global_command, create_guild_command, delete_global_command, delete_guild_command, delete_guild_commands, edit_global_command, edit_guild_command, get_command, get_command_permissions, get_global_commands, get_guild_commands, delete_global_commands, get_id, update_command_permissions
 from .slash.types import AdditionalType, CommandType, ContextCommand, MessageCommand, OptionType, SlashCommand, SlashOption, SlashSubcommand, UserCommand
-from .tools import MISSING, _none, _or, get_index, setup_logger
+from .tools import MISSING, _none, _or, get_index, setup_logger, get
 from .http import jsonifyMessage, BetterRoute, send_files
 from .receive import ComponentContext, Interaction, Message, PressedButton, SelectedMenu, SlashedContext, WebhookMessage, SlashedCommand, SlashedSubCommand, getMessage
 from .override import override_dpy as override_it
@@ -124,7 +124,7 @@ def add_cog_override(*args, **kwargs):
                 self._add_to_cache(com)
             old_add(*args, **kwargs)
             if self.ready is True and sync_on_cog is True:
-                self._discord.loop.create_task(self.sync_commands(self.delete_unused))
+                self._discord.loop.run_until_complete(self.sync_commands(self.delete_unused))
         self._discord.add_cog = add_cog_override
 
         old_remove = self._discord.remove_cog
@@ -135,7 +135,7 @@ def remove_cog_override(*args, **kwargs):
                 self._remove_from_cache(com)
             old_remove(*args, **kwargs)
             if self.ready is True and sync_on_cog is True:
-                self._discord.loop.create_task(self.sync_commands(self.delete_unused))
+                self._discord.loop.run_until_complete(self.sync_commands(self.delete_unused))
         self._discord.remove_cog = remove_cog_override
 
         async def on_connect():
@@ -397,7 +397,7 @@ async def _get_guild_commands(self, guild_id: str) -> List[dict]:
         logging.debug("getting guild commands in " + str(guild_id))
         return await get_guild_commands(self._discord, guild_id)
 
-    def gather_commands(self):
+    def gather_commands(self) -> Dict[str, SlashCommand]:
         commands = self.commands.copy()
         for _base in self.subcommands:
             # get first base
@@ -644,7 +644,7 @@ async def edit_command(self, old_name, typ: Literal["slash", 1, "user", 2, "mess
         else:
             await self.create_command(command)
         self._set_command(old_name, command)
-
+   
     def _get_command(self, name, typ: Literal["slash", 1, "user", 2, "message", 3]) -> SlashCommand:
         typ = CommandType.from_string(typ)
         if typ == CommandType.SLASH:

discord_ui/override.py

@@ -39,14 +39,8 @@ def override_dpy():
 
     #region message override
     async def send(self: discord.TextChannel, content=None, **kwargs) -> Message:
-        channel_id = self.id if not isinstance(self, commands.Context) else self.channel.id
-
-        channel = None
-        if isinstance(self, (discord.Member, discord.User)) and self.dm_channel is None:
-                channel = await self.create_dm()
-                channel_id = channel.id
-        
-        route = BetterRoute("POST", f"/channels/{channel_id}/messages")
+        channel = await self._get_channel()
+        route = BetterRoute("POST", f"/channels/{channel.id}/messages")
 
         r = None
         if kwargs.get("file") is None and kwargs.get("files") is None:
@@ -60,8 +54,6 @@ async def send(self: discord.TextChannel, content=None, **kwargs) -> Message:
             payload = jsonifyMessage(content=content, **kwargs)
             r = await send_files(route, files=files, payload=payload, http=self._state.http)
 
-        if channel is None:
-            channel = self if not isinstance(self, commands.Context) else self.channel
         msg = Message(state=self._state, channel=channel, data=r)
         if kwargs.get("delete_after") is not None:
             await msg.delete(delay=kwargs.get("delete_after"))

discord_ui/receive.py

@@ -1,6 +1,6 @@
 from .errors import InvalidEvent, OutOfValidRange, WrongType
 from .slash.errors import AlreadyDeferred, EphemeralDeletion
-from .slash.types import ContextCommand, SlashCommand, SlashPermission, SlashSubcommand
+from .slash.types import ContextCommand, OptionType, SlashCommand, SlashPermission, SlashSubcommand
 from .tools import MISSING, setup_logger, _none
 from .http import BetterRoute, jsonifyMessage, send_files
 from .components import ActionRow, Button, Component, LinkButton, SelectMenu, SelectOption, make_component
@@ -317,7 +317,18 @@ class SlashedSubCommand(SlashedCommand, SlashSubcommand):
     """A Sub-:class:`~SlashCommand` command that was used"""
     def __init__(self, client, command, data, user, args = None, guild_ids = None, guild_permissions=None) -> None:
         SlashedCommand.__init__(self, client, command, data, user, args, guild_ids=guild_ids, guild_permissions=guild_permissions)
-        SlashSubcommand.__init__(self, None, "EMPTY", "EMPTY")
+        print(data)
+        SlashSubcommand.__init__(self, None, ["EMPTY"], "EMPTY")
+        self.base_names[0] = data["data"]["name"]
+        _sub = data["data"]["options"][0]
+        if _sub["type"] == OptionType.SUB_COMMAND_GROUP:
+            print("group")
+            self.base_names.append(_sub["name"])
+            self.name = _sub["options"][0]["name"]
+        else:
+            print("sub")
+            self.name = _sub["name"]
+            
 
 class SlashedContext(Interaction, ContextCommand):
     def __init__(self, client, command: ContextCommand, data, user, param, guild_ids = None, guild_permissions = None) -> None: