Adding a bot with no permissions shouldn't create an unnecessary role

[Nicofisi]

When you include a permissions=0 in the bot authorize URL, it won't create a role for the bot automatically.

However, when you include a non-zero value, and uncheck all the permissions before continuing, it will still create the role. This is annoying as a server owner, since I can't use the new feature of adding bots in-app on Desktop, because by default most of those links include some permissions, and if I don't want to be forced to have an undeletable role, I can't do anything about it. I need to open the link in the browser and change the permissions to 0 in the URL.

This problematic role is created both in the Desktop app and on the website version of the authorize URL.

---

On the other hand, why can't the role be deleted, if it is possible for it not to exist in the first place?

TL;DR: it shouldn't matter whether the bot got invited with no permissions due to a user unchecking them with the checkboxes, or due to the user modifying the URL - the behavior should be the same

[advaith1]

I can't repro this bug - I just added carl-bot in the client (using the Add to Server button) and unchecked all of the permissions, and no role was created.

Tested on:

• desktop Canary 118279 (d2f321c) Host 1.0.45 Windows 10 64-Bit (10.0.22000)
• web Canary 118378 (27d1b9e) Windows 10 64-Bit
• web stable oauth2 page

[Nicofisi]

What link did you use for the invite? Or was it with 'Add bot' on the bot profile?

[Nicofisi]

Here one example:

Discord_o5cvngUlvZ.mp4

Stable 118205 (081ceba) Host 1.0.9004 Windows 10 64-Bit (10.0.19044)

[Nicofisi]

Actually it seems to work as expected on the web oauth page for me too now - that's quite new, it hasn't been for a few years

[devsnek]

i'm also unable to reproduce this. if you've been testing this a bunch, make sure you cleaned up the bot and roles before trying to invite it again?

[Nicofisi]

We figured the problem with @advaith1 in DMs and I created a bug issue in #4638 about it with steps to reproduce

(@devsnek)