Fix Social SDK examples from Direct Messages and Friend List #7532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
approved these changes
Apr 29, 2025
Contributor
markmandel
left a comment
markmandel
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the fixes! Will go live on the next publish.
|
|
||
| ```cpp | ||
| void DisplayFriendsList(discordpp::Client& client) { | ||
| void DisplayFriendsList(std::shared_ptr<discordpp::Client> client) { |
|
|
||
| // Categorize based on status | ||
| if (user->Status() != discordpp::StatusType::Offline) { | ||
| if (user->GameActivity()) { |
Contributor
There was a problem hiding this comment.
Nice, since GameActivity() returns std::optional 👍🏻
mazylol
pushed a commit
to mazylol/discord-api-docs
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sending Direct Messages - Sending a Direct Message to a User, it calls
result.GetError()when it should beresult.Error().In Creating a Unified Friend List - Step 2: Organize Relationships,
inGamevector is never filled.I'm assuming that this is how I'm suppose to fill because previous example from this page showed:
Also in Creating a Unified Friend List - Step 2: Organize Relationships,
DisplayFriendsListsignature is probably wrong because the code treat client as a pointer (client->GetRelationships()).I'm assuming that it's a
std::shared_ptr<discordpp::Client>because in it is in Getting Started with C++ and the Discord Social SDK.