Skip to content

feat: add new URL fields #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

feat: add new URL fields #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/commands/setActivity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ import {commandFactory} from '../utils/commandFactory';

export const SetActivity = Activity.pick({
state: true,
state_url: true,
details: true,
details_url: true,
timestamps: true,
assets: true,
party: true,
Expand Down
4 changes: 4 additions & 0 deletions src/schema/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,9 @@ export const Activity = zod.object({
.nullable(),
application_id: zod.string().optional().nullable(),
details: zod.string().optional().nullable(),
details_url: zod.string().url().optional().nullable(),
state: zod.string().optional().nullable(),
state_url: zod.string().url().optional().nullable(),
emoji: Emoji.optional().nullable(),
party: zod
.object({
Expand All @@ -167,8 +169,10 @@ export const Activity = zod.object({
.object({
large_image: zod.string().nullable(),
large_text: zod.string().nullable(),
large_url: zod.string().url().optional().nullable(),
small_image: zod.string().nullable(),
small_text: zod.string().nullable(),
small_url: zod.string().url().optional().nullable(),
Comment on lines 170 to +175
Copy link
Contributor

@advaith1 advaith1 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure if we want only the _url fields to be optional but idk why some fields are only nullable and some fields are optional + nullable in the existing code.

Copy link
Contributor Author

@foxfirecodes foxfirecodes Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did optional + nullable to align with what details and state had -- i imagine the reason why large/small_image/text are nullable but not optional is that the intention is if (assets) { images & text should be defined }

})
.partial()
.optional()
Expand Down