Skip to content

Commit 247655e

Browse files
authored
reapply logs (#124)
1 parent 4169376 commit 247655e

File tree

3 files changed

+16
-0
lines changed

3 files changed

+16
-0
lines changed

packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricUIManagerBinding.cpp

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -631,10 +631,18 @@ void FabricUIManagerBinding::schedulerShouldRenderTransactions(
631631
/* willPerformAsynchronously = */ true);
632632
if (mountingTransaction.has_value()) {
633633
auto transaction = std::move(*mountingTransaction);
634+
LOG(WARNING) << "⚙️ schedulerShouldRenderTransactions (enableAccumulatedUpdatesInRawPropsAndroid), items: "
635+
<< mountingTransaction->getMutations().size()
636+
<< " pending mounting transaction(s) for new base revision: "
637+
<< mountingCoordinator->getBaseRevision().number;
634638
mountingManager->executeMount(transaction);
635639
}
636640
} else {
637641
std::vector<MountingTransaction> pendingTransactions;
642+
LOG(WARNING) << "⚙️ schedulerShouldRenderTransactions "
643+
<< pendingTransactions_.size()
644+
<< " pending mounting transaction(s) for new base revision: "
645+
<< mountingCoordinator->getBaseRevision().number;
638646

639647
{
640648
// Retain the lock to access the pending transactions but not to execute

packages/react-native/ReactCommon/react/renderer/mounting/MountingCoordinator.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ std::optional<MountingTransaction> MountingCoordinator::pullTransaction(
9595

9696
telemetry.willDiff();
9797

98+
LOG(WARNING) << "⚙️ Diffing revision " << baseRevision_.number
99+
<< " to " << lastRevision_->number;
98100
auto mutations = calculateShadowViewMutations(
99101
*baseRevision_.rootShadowNode, *lastRevision_->rootShadowNode);
100102

packages/react-native/ReactCommon/react/renderer/mounting/ShadowTree.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,9 +395,15 @@ void ShadowTree::mount(ShadowTreeRevision revision, bool mountSynchronously)
395395
// TODO: can a mount cause another mount, so we have to care about reentrancy?
396396
lock = std::unique_lock<std::shared_mutex>(mountMutex_);
397397
}
398+
399+
LOG(WARNING) << "⚙️ Mounting revision " << revision.number
400+
<< " (" << (mountSynchronously ? "synchronously" : "asynchronously") << ")"
401+
<< ", shouldLock: " << (shouldLock ? "true" : "false");
398402
mountingCoordinator_->push(std::move(revision));
399403
delegate_.shadowTreeDidFinishTransaction(
400404
mountingCoordinator_, mountSynchronously);
405+
LOG(WARNING) << "☑️ Finished mount-phase revision " << revision.number
406+
<< " (" << (mountSynchronously ? "synchronously" : "asynchronously") << ")";
401407
}
402408

403409
void ShadowTree::commitEmptyTree() const {

0 commit comments

Comments
 (0)