fix: add guild_id back to GatewayVoiceStateUpdateDispatchData #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Jiralite
previously approved these changes
Aug 28, 2025
Qjuh
reviewed
Aug 29, 2025
| /** | ||
| * The guild member this voice state is for | ||
| * | ||
| * @remarks The member field will have `joined_at` set to `null` if the member was invited as a guest. |
Member
There was a problem hiding this comment.
This remark should be kept with the move back to APIBaseVoiceState, not removed.
Contributor
Author
There was a problem hiding this comment.
Actually upon further consideration, would it not make more sense to move this to APIGuildMemberJoined#joined_at itself? I figure it was originally added here due to the same misconception that created APIVoiceStateMember in the first place.
vladfrangu
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#1290 accidentally stripped the
guild_idfromGatewayVoiceStateUpdateDispatchData. After re-adding this back, I noticed it loops back around to being 1:1 withAPIVoiceStatemaking the whole change toGatewayVoiceStateUpdateDispatchDataunnecessary in the first place.As for how
GatewayVoiceStateUpdateDispatchDatawas used inGatewayGuildCreateDispatchData, I noticed the aforementioned PR already looped back around toAPIVoiceStateMember#memberbeing the same as it was originally asAPIBaseVoiceState#member. So, the changes toGatewayGuildCreateDispatchDataandAPIBaseVoiceStatewere also unnecessary.Therefore, this partially reverts #1290.
If applicable, please reference Discord API Docs PRs or commits that influenced this PR: