refactor(Role)!: remove color

Author: sdanialraza

packages/discord.js/src/managers/GuildMemberRoleManager.js

@@ -72,7 +72,7 @@ class GuildMemberRoleManager extends DataManager {
    * @readonly
    */
   get color() {
-    const coloredRoles = this.cache.filter(role => role.color);
+    const coloredRoles = this.cache.filter(role => role.colors.primaryColor);
     if (!coloredRoles.size) return null;
     return coloredRoles.reduce((prev, role) => (role.comparePositionTo(prev) > 0 ? role : prev));
   }

packages/discord.js/src/managers/RoleManager.js

@@ -123,8 +123,6 @@ class RoleManager extends CachedManager {
    *
    * @typedef {Object} RoleCreateOptions
    * @property {string} [name] The name of the new role
-   * @property {ColorResolvable} [color] The color to create the role with.
-   * This will still be returned by the API, but using the `colors` field is recommended when doing requests
    * @property {RoleColors} [colors] The colors to create the role with
    * @property {boolean} [hoist] Whether or not the new role should be hoisted
    * @property {PermissionResolvable} [permissions] The permissions for the new role
@@ -152,16 +150,17 @@ class RoleManager extends CachedManager {
    * // Create a new role with data and a reason
    * guild.roles.create({
    *   name: 'Super Cool Blue People',
-   *   color: Colors.Blue,
    *   reason: 'we needed a role for Super Cool People',
+   *   colors: {
+   *     primaryColor: Colors.Blue,
+   *   },
    * })
    *   .then(console.log)
    *   .catch(console.error);
    */
   async create(options = {}) {
-    let { color, permissions, icon } = options;
+    let { permissions, icon } = options;
     const { name, hoist, position, mentionable, reason, unicodeEmoji } = options;
-    color &&= resolveColor(color);
     if (permissions !== undefined) permissions = new PermissionsBitField(permissions);
     if (icon) {
       const guildEmojiURL = this.guild.emojis.resolve(icon)?.imageURL();
@@ -178,7 +177,6 @@ class RoleManager extends CachedManager {
     const data = await this.client.rest.post(Routes.guildRoles(this.guild.id), {
       body: {
         name,
-        color,
         colors,
         hoist,
         permissions,
@@ -238,7 +236,6 @@ class RoleManager extends CachedManager {
 
     const body = {
       name: options.name,
-      color: options.color === undefined ? undefined : resolveColor(options.color),
       colors,
       hoist: options.hoist,
       permissions: options.permissions === undefined ? undefined : new PermissionsBitField(options.permissions),

packages/discord.js/src/structures/Role.js

@@ -57,15 +57,6 @@ class Role extends Base {
       this.name = data.name;
     }
 
-    if ('color' in data) {
-      /**
-       * The base 10 color of the role
-       *
-       * @type {number}
-       */
-      this.color = data.color;
-    }
-
     if ('colors' in data) {
       /**
        * The colors of the role
@@ -270,8 +261,6 @@ class Role extends Base {
    *
    * @typedef {Object} RoleData
    * @property {string} [name] The name of the role
-   * @property {ColorResolvable} [color] The color of the role, either a hex string or a base 10 number.
-   * This will still be returned by the API, but using the `colors` field is recommended when doing requests
    * @property {RoleColors} [colors] The colors of the role
    * @property {boolean} [hoist] Whether or not the role should be hoisted
    * @property {number} [position] The position of the role
@@ -329,22 +318,6 @@ class Role extends Base {
     return this.edit({ name, reason });
   }
 
-  /**
-   * Sets a new color for the role.
-   *
-   * @param {ColorResolvable} color The color of the role
-   * @param {string} [reason] Reason for changing the role's color
-   * @returns {Promise<Role>}
-   * @example
-   * // Set the color of a role
-   * role.setColor('#FF0000')
-   *   .then(updated => console.log(`Set color of role to ${updated.color}`))
-   *   .catch(console.error);
-   */
-  async setColor(color, reason) {
-    return this.edit({ color, reason });
-  }
-
   /**
    * Sets new colors for the role.
    *
@@ -506,7 +479,6 @@ class Role extends Base {
       role &&
       this.id === role.id &&
       this.name === role.name &&
-      this.color === role.color &&
       this.colors.primaryColor === role.colors.primaryColor &&
       this.colors.secondaryColor === role.colors.secondaryColor &&
       this.colors.tertiaryColor === role.colors.tertiaryColor &&

packages/discord.js/typings/index.d.ts

@@ -2842,7 +2842,6 @@ export interface RoleColors {
 
 export class Role extends Base {
   private constructor(client: Client<true>, data: APIRole, guild: Guild);
-  public color: number;
   public colors: RoleColors;
   public get createdAt(): Date;
   public get createdTimestamp(): number;
@@ -2871,7 +2870,6 @@ export class Role extends Base {
     channel: NonThreadGuildBasedChannel | Snowflake,
     checkAdmin?: boolean,
   ): Readonly<PermissionsBitField>;
-  public setColor(color: ColorResolvable, reason?: string): Promise<Role>;
   public setColors(colors: RoleColors, reason?: string): Promise<Role>;
   public setHoist(hoist?: boolean, reason?: string): Promise<Role>;
   public setMentionable(mentionable?: boolean, reason?: string): Promise<Role>;
@@ -6805,7 +6803,6 @@ export interface ResolvedOverwriteOptions {
 }
 
 export interface RoleData {
-  color?: ColorResolvable;
   colors?: RoleColors;
   hoist?: boolean;
   icon?: Base64Resolvable | BufferResolvable | EmojiResolvable | null;