fix: typing mismatch for empty strings being treated as undefined

Author: WhatCats

packages/discord.js/src/managers/ApplicationCommandManager.js

@@ -123,7 +123,9 @@ class ApplicationCommandManager extends CachedManager {
    *   .catch(console.error)
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
 
     if (typeof options === 'string') return this._fetchSingle({ id: options });
 

packages/discord.js/src/managers/ApplicationEmojiManager.js

@@ -80,7 +80,7 @@ class ApplicationEmojiManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(id, { cache = true, force = false } = {}) {
-    if (id) {
+    if (id !== undefined) {
       if (!force) {
         const existing = this.cache.get(id);
         if (existing) return existing;

packages/discord.js/src/managers/AutoModerationRuleManager.js

@@ -265,7 +265,10 @@ class AutoModerationRuleManager extends CachedManager {
    *   .catch(console.error)
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
+
     const { autoModerationRule, cache, force } = options;
     const resolvedAutoModerationRule = this.resolveId(autoModerationRule ?? options);
     if (resolvedAutoModerationRule) {

packages/discord.js/src/managers/EntitlementManager.js

@@ -72,11 +72,13 @@ class EntitlementManager extends CachedManager {
    * @returns {Promise<Entitlement|Collection<Snowflake, Entitlement>>}
    */
   async fetch(options) {
-    if (!options) return this._fetchMany(options);
+    if (options === undefined) {
+      return this._fetchMany(options);
+    }
+
     const { entitlement, cache, force } = options;
     const resolvedEntitlement = this.resolveId(entitlement ?? options);
-
-    if (resolvedEntitlement) {
+    if (resolvedEntitlement !== null) {
       return this._fetchSingle({ entitlement: resolvedEntitlement, cache, force });
     }
 

packages/discord.js/src/managers/GuildBanManager.js

@@ -102,10 +102,15 @@ class GuildBanManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
+
     const { user, cache, force, limit, before, after } = options;
     const resolvedUser = this.client.users.resolveId(user ?? options);
-    if (resolvedUser) return this._fetchSingle({ user: resolvedUser, cache, force });
+    if (resolvedUser !== null) {
+      return this._fetchSingle({ user: resolvedUser, cache, force });
+    }
 
     if (!before && !after && !limit && cache === undefined) {
       throw new DiscordjsError(ErrorCodes.FetchBanResolveId);

packages/discord.js/src/managers/GuildChannelManager.js

@@ -418,12 +418,12 @@ class GuildChannelManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(id, { cache = true, force = false } = {}) {
-    if (id && !force) {
+    if (id !== undefined && !force) {
       const existing = this.cache.get(id);
       if (existing) return existing;
     }
 
-    if (id) {
+    if (id !== undefined) {
       const innerData = await this.client.rest.get(Routes.channel(id));
       // Since this is the guild manager, throw if on a different guild
       if (this.guild.id !== innerData.guild_id) throw new DiscordjsError(ErrorCodes.GuildChannelUnowned);

packages/discord.js/src/managers/GuildEmojiManager.js

@@ -179,7 +179,7 @@ class GuildEmojiManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(id, { cache = true, force = false } = {}) {
-    if (id) {
+    if (id !== undefined) {
       if (!force) {
         const existing = this.cache.get(id);
         if (existing) return existing;

packages/discord.js/src/managers/GuildInviteManager.js

@@ -142,7 +142,10 @@ class GuildInviteManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
+
     if (typeof options === 'string') {
       const code = resolveInviteCode(options);
       if (!code) throw new DiscordjsError(ErrorCodes.InviteResolveCode);

packages/discord.js/src/managers/GuildMemberManager.js

@@ -217,10 +217,16 @@ class GuildMemberManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
+
     const { user: users, limit, withPresences, cache, force } = options;
     const resolvedUser = this.client.users.resolveId(users ?? options);
-    if (resolvedUser && !limit && !withPresences) return this._fetchSingle({ user: resolvedUser, cache, force });
+    if (resolvedUser !== null && !limit && !withPresences) {
+      return this._fetchSingle({ user: resolvedUser, cache, force });
+    }
+
     const resolvedUsers = users?.map?.(user => this.client.users.resolveId(user)) ?? resolvedUser ?? undefined;
     return this._fetchMany({ ...options, users: resolvedUsers });
   }

packages/discord.js/src/managers/GuildSoundboardSoundManager.js

@@ -199,10 +199,16 @@ class GuildSoundboardSoundManager extends CachedManager {
    *   .catch(console.error);
    */
   async fetch(options) {
-    if (!options) return this._fetchMany();
+    if (options === undefined) {
+      return this._fetchMany();
+    }
+
     const { cache, force, soundboardSound } = options;
     const resolvedSoundboardSound = this.resolveId(soundboardSound ?? options);
-    if (resolvedSoundboardSound) return this._fetchSingle({ cache, force, soundboardSound: resolvedSoundboardSound });
+    if (resolvedSoundboardSound !== null) {
+      return this._fetchSingle({ cache, force, soundboardSound: resolvedSoundboardSound });
+    }
+
     return this._fetchMany({ cache });
   }