Callback param types on messageReactionAdd not working

[SayakMukhopadhyay]

I am having a weird issue while developing in typescript. I am trying to listen to the messageReactionAdd event and want to type the listener function parameters. Example code

this.client.on('messageReactionAdd', (reaction: MessageReaction, user: User) => {
  //code
});

Typescript doesn't like it and says "No overload matches this call".

If I change the moduleResolution type to classic from node, this error doesn't appear anymore. Moreover, this error didnt happen with the same code in v12. This is the difference in the same definition in 12 vs 13

Seems like the typings were changed. So, if I manually edit the typing to change it back to v12 style, things work as expected.
What's going wrong? Any ideas?

[ImRodry]

You shouldn’t cast the type of reaction and user, they will be casted automatically. Along with that make sure you’re not returning anything in the event, you must always return void

[SayakMukhopadhyay]

Thing is in webstorm, if I just do

this.client.on('messageReactionAdd', (reaction, user) => {
  reaction.message
  user.client
});

The type of reaction is getting shown as any

The type hints still show the correct hints and it works without a hitch in VSCode. Even doing

this.client.on('messageReactionAdd', (reaction: MessageReaction, user: User) => {
  //code
});

works fine in VSCode.

[ImRodry]

You should really be using VSCode for TypeScript, it's the most optimized IE

[monbrey]

Definitely seems to be Webstorm at fault here, if you look at the error it appears to be inserting additional any args before each of the real ones.

args_0 and args_2 shouldn't exist - no idea where they're coming from. What Webstorm seems to think are args_1 and args_3 are the real ones, which also seems to align with the typings you're seeing on hover.

[SayakMukhopadhyay]

Yeah. I think I will create a small reproduction and raise it with JB. Thanks for the insights!

[SayakMukhopadhyay]

I just tried building my project and it failed. I can reproduce this issue. See https://codesandbox.io/s/discord-js-typings-bug-8zif7. If you want to run commands, please fork the sandbox and create a new terminal to run the build script. Here is what I got