fix(server/permissions): update bot permissions checks to only require "Create Guild Expressions"

Author: skyhancloud

server/src/bot/commands/features/emoji.js

@@ -51,7 +51,7 @@ module.exports = {
   isGuildOnly: true,
   execute: async interaction => {
     if (!interaction.member.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions)) return interaction.reply(await interaction.translate('commands.shared.errors.missing_permissions'));
-    if (!interaction.guild.members.me.permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions) && !interaction.guild.members.me.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions)) return interaction.reply(await interaction.translate('commands.emoji.errors.missing_bot_permissions'));
+    if (!interaction.guild.members.me.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions) && !interaction.guild.members.me.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions)) return interaction.reply(await interaction.translate('commands.emoji.errors.missing_bot_permissions'));
 
     await interaction.deferReply();
 
@@ -167,7 +167,7 @@ module.exports = {
     }
   },
   autocomplete: async interaction => {
-    if (!interaction.member.permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions)) return;
+    if (!interaction.member.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions)) return;
 
     const group = interaction.options.getSubcommandGroup(false);
 

server/src/locales/en.json

@@ -29,7 +29,7 @@
     },
     "emoji": {
       "errors": {
-        "missing_bot_permissions": "I don't have permission to upload emojis. Please make sure I have the \"Manage Guild Expressions\" and \"Create Guild Expressions\" permissions.",
+        "missing_bot_permissions": "I don't have permission to upload emojis. Please make sure I have the \"Create Guild Expressions\" permission.",
         "pack_not_found": "Pack not found.",
         "currently_uploading": {
           "message": "I'm currently uploading the pack **{packName}**. Please wait until it's finished.",

server/src/locales/tr.json

@@ -29,7 +29,7 @@
     },
     "emoji": {
       "errors": {
-        "missing_bot_permissions": "Emoji yüklemek için yetkim yok. Lütfen \"İfadeleri Yönet\" ve \"İfadeler Oluştur\" izinlerine sahip olduğumdan emin olun.",
+        "missing_bot_permissions": "Emoji yüklemek için yetkim yok. Lütfen \"İfadeler Oluştur\" iznine sahip olduğumdan emin olun.",
         "pack_not_found": "Emoji paketi bulunamadı.",
         "currently_uploading": {
           "message": "Şu anda **{packName}** paketini yüklüyorum. Lütfen bitene kadar bekleyin.",

server/src/routes/auth/@me/emoji-uploadable-guilds.js

@@ -16,7 +16,7 @@ module.exports = {
       const emojiUploadableGuilds = guilds.filter(guild => {
         const permissions = new Discord.PermissionsBitField(guild.permissions_new);
 
-        return guild.owner === true || permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions);
+        return guild.owner === true || permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions);
       });
 
       const botGuilds = client.guilds.cache.map(guild => guild.id);

server/src/routes/auth/@me/sound-uploadable-guilds.js

@@ -16,7 +16,7 @@ module.exports = {
       const soundUploadableGuilds = guilds.filter(guild => {
         const permissions = new Discord.PermissionsBitField(guild.permissions_new);
 
-        return guild.owner === true || permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions);
+        return guild.owner === true || permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions);
       });
 
       const botGuilds = client.guilds.cache.map(guild => guild.id);

server/src/routes/emojis/[id]/upload-to-guild.js

@@ -28,8 +28,8 @@ module.exports = {
       const member = guild.members.cache.get(request.user.id) || await guild.members.fetch(request.user.id).catch(() => null);
       if (!member) return response.sendError('You are not a member of this guild.', 403);
 
-      const hasPermission = member.permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions);
-      if (!hasPermission) return response.sendError('You do not have permission to manage emojis in this guild.', 403);
+      const hasPermission = member.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions);
+      if (!hasPermission) return response.sendError('You do not have permission to create emojis in this guild.', 403);
 
       const emoji = await Emoji.findOne({ id });
       if (!emoji) return response.sendError('Emoji not found.', 404);

server/src/routes/sounds/[id]/upload-to-guild.js

@@ -32,7 +32,7 @@ module.exports = {
       const member = guild.members.cache.get(request.user.id) || await guild.members.fetch(request.user.id).catch(() => null);
       if (!member) return response.sendError('You are not a member of this guild.', 403);
 
-      const hasPermission = member.permissions.has(Discord.PermissionFlagsBits.ManageGuildExpressions);
+      const hasPermission = member.permissions.has(Discord.PermissionFlagsBits.CreateGuildExpressions);
       if (!hasPermission) return response.sendError('You do not have the required permissions to upload sounds to this guild.', 403);
 
       try {